Developer forums (C::B DEVELOPMENT STRICTLY!) > Development

Build CodeBlocks using Microsoft Visual C++

<< < (4/10) > >>

xunxun:

--- Quote from: ollydbg on April 06, 2011, 07:05:38 am ---@loaden
it seems you add a lot of DLLIMPORT before the class declaration. But why they are not needed when build with MinGW GCC?

--- End quote ---
Because MinGW GCC export  all symbols defaultly.

Loaden:

--- Quote from: ollydbg on April 06, 2011, 07:05:38 am ---@loaden
You patches v6 contains a lot of duplicated piece code. (which means: you don't change anything on the code, maybe, there are some space, tabs added/moved)

--- End quote ---
Sure, I am re-make the patch now.

[attachment deleted by admin]

oBFusCATed:
Simple question: have you tried to compile C::B with gcc on windows and linux with your patch applied, I think you will have problems :)
Also why is that "" to _T("") needed all over the place?


--- Quote from: Loaden on April 06, 2011, 06:39:45 am ---I don't think so, Only need a little guard code (like #ifdef _MSC_VER), and seems very clearly.

--- End quote ---
Hm, your patch is 120+ KB, so the changes aren't minimal :)

Also:
1. Have you tried to use something different from vc 2010?
2. Don't compile add C++ features to C files (VC always compiles .c files as C++ and you should tell it to compile it as C with some compiler flag) (I'm talking about the files in depslib)
3. Don't call that start with _ they are MS only most of the time
4. When there is a missing function, you should reimplement it, not add #ifdef #else #endif guards

Loaden:

--- Quote from: oBFusCATed on April 06, 2011, 08:56:48 am ---Simple question: have you tried to compile C::B with gcc on windows and linux with your patch applied, I think you will have problems :)

--- End quote ---
I am *only* test it using GCC 4.4.4 on Windows 7 SP1 / XPSP3, and it's works well.



--- Quote from: oBFusCATed on April 06, 2011, 08:56:48 am ---
--- Quote from: Loaden on April 06, 2011, 06:39:45 am ---I don't think so, Only need a little guard code (like #ifdef _MSC_VER), and seems very clearly.

--- End quote ---
Hm, your patch is 120+ KB, so the changes aren't minimal :)

--- End quote ---
Most of them are Multi-line String fixed.
e.g.
Change from:
_("aaa"
   "bbb")
TO:
_("aaa"
   _T("bbb"))



--- Quote from: oBFusCATed on April 06, 2011, 08:56:48 am ---Also:
1. Have you tried to use something different from vc 2010?
2. Don't compile add C++ features to C files (VC always compiles .c files as C++ and you should tell it to compile it as C with some compiler flag) (I'm talking about the files in depslib)
3. Don't call that start with _ they are MS only most of the time
4. When there is a missing function, you should reimplement it, not add #ifdef #else #endif guards

--- End quote ---
1. No
2. I am using /TP flags, Why not? What is the reason?
3. Revert the changes in V8 patch
4. Only two case:
   (1)
   #ifndef _MSC_VER // TODO (Loaden#5#) error C2017: illegal escape sequence
        Quoted.Replace(wxString(_T("‘")), _T("\""), true);
        Quoted.Replace(_T("’"), _T("\""), true);
   #endif
   (2)
   #ifndef _MSC_VER // TODO (Loaden#1#) MSVC can't support gettimeofday
   #include <sys/time.h>
   #endif

Many thanks for feedback!!

ollydbg:
Hey, loaden, unpack the 23K 7zip file, the patch is still 131K, Oh my God. :D

But, I review the patch, it does change only a little code. :D

Navigation

[0] Message Index

[#] Next page

[*] Previous page