Simple question: have you tried to compile C::B with gcc on windows and linux with your patch applied, I think you will have problems
I am *only* test it using GCC 4.4.4 on Windows 7 SP1 / XPSP3, and it's works well.
I don't think so, Only need a little guard code (like #ifdef _MSC_VER), and seems very clearly.
Hm, your patch is 120+ KB, so the changes aren't minimal
Most of them are Multi-line String fixed.
e.g.
Change from:
_("aaa"
"bbb")
TO:
_("aaa"
_T("bbb"))
Also:
1. Have you tried to use something different from vc 2010?
2. Don't compile add C++ features to C files (VC always compiles .c files as C++ and you should tell it to compile it as C with some compiler flag) (I'm talking about the files in depslib)
3. Don't call that start with _ they are MS only most of the time
4. When there is a missing function, you should reimplement it, not add #ifdef #else #endif guards
1. No
2. I am using /TP flags, Why not? What is the reason?
3. Revert the changes in V8 patch
4. Only two case:
(1)
#ifndef _MSC_VER // TODO (Loaden#5#) error C2017: illegal escape sequence
Quoted.Replace(wxString(_T("‘")), _T("\""), true);
Quoted.Replace(_T("’"), _T("\""), true);
#endif
(2)
#ifndef _MSC_VER // TODO (Loaden#1#) MSVC can't support gettimeofday
#include <sys/time.h>
#endif
Many thanks for feedback!!