User forums > Nightly builds

The 06 March 2011 build (7040) is out.

<< < (5/8) > >>

oBFusCATed:
Yes, I'll look at it :)

ollydbg:
By reading the CC's source code these days, I just realize that "calltip" and "valuetip" are not the same thing. :D, I do not quite understand this before.

call tip is some tips showing when user were entering a function call statement, it assist the user by highlight the current function argument. call tips can fired by user adding a char, or by short cut key. it surely need to count the "commas" numbers user has already entered.

value tip is some tips that when you mouse hover an identifier, the tips contains the "type" information about the current token under mouse.

so, I think some comments which I created before in CC was wrong, I will try to fix them. :D

oBFusCATed:
Probably something like that should fix the bug: http://smrt.is-a-geek.org/codeblocks/patches/call_tip_highlight1.patch

The patch is tested only on a small example, so please test and report if there are problems with it.
If there are no problems in the next week, I'll commit it.  :lol:

ollydbg:

--- Quote from: oBFusCATed on April 02, 2011, 07:47:13 pm ---Probably something like that should fix the bug: http://smrt.is-a-geek.org/codeblocks/patches/call_tip_highlight1.patch

The patch is tested only on a small example, so please test and report if there are problems with it.
If there are no problems in the next week, I'll commit it.  :lol:

--- End quote ---
nice, one thing I should suggest is :


--- Code: ---        while (--pos > 0)
        {
            const int style = searchData.control->GetStyleAt(pos);
            if (   searchData.control->IsString(style)
                || searchData.control->IsCharacter(style)
                || searchData.control->IsComment(style) )
            {
                continue;
            }

            const wxChar ch = searchData.control->GetCharAt(pos);
            if (ch == _T(';'))
                return;

--- End code ---

this is a "backword" search, I think it should break on a "{".

so

--- Code: ---            if (ch == _T(';')  || ch == _T('{')  )
                return;
--- End code ---

and, for a consistent, the "(" we call open parenthesis instead of open bracket.

see: in the parserthread.cpp

--- Code: ---namespace ParserConsts
{
    const wxString space           (_T(" "));
    const wxString spaced_colon    (_T(" : "));
    const wxString empty           (_T(""));
    const wxString equals          (_T("="));
    const wxString hash            (_T("#"));
    const wxString plus            (_T("+"));
    const wxString asterisk        (_T("*"));
    const wxString comma           (_T(","));
    const wxString commaclbrace    (_T(",}"));
    const wxString dash            (_T("-"));
    const wxString dot             (_T("."));
    const wxString colon           (_T(":"));
    const wxString dcolon          (_T("::"));
    const wxString semicolon       (_T(";"));
    const wxString semicolonopbrace(_T(";{"));
    const wxString semicolonclbrace(_T(";}"));
    const wxString lt              (_T("<"));
    const wxString gt              (_T(">"));
    const wxString gtsemicolon     (_T(">;"));
    const wxString quot            (_T("\""));
    const wxString kw_C            (_T("\"C\""));
    const wxString kw_CPP          (_T("\"C++\""));
    const wxString kw__asm         (_T("__asm"));
    const wxString kw_class        (_T("class"));
    const wxString kw_const        (_T("const"));
    const wxString kw_define       (_T("define"));
    const wxString kw_undef        (_T("undef"));
    const wxString kw_delete       (_T("delete"));
    const wxString kw_do           (_T("do"));
    const wxString kw_else         (_T("else"));
    const wxString kw_enum         (_T("enum"));
    const wxString kw_extern       (_T("extern"));
    const wxString kw_for          (_T("for"));
    const wxString kw_friend       (_T("friend"));
    const wxString kw_if           (_T("if"));
    const wxString kw_elif         (_T("elif"));
    const wxString kw_include      (_T("include"));
    const wxString kw_inline       (_T("inline"));
    const wxString kw_namespace    (_T("namespace"));
    const wxString kw_operator     (_T("operator"));
    const wxString kw_private      (_T("private"));
    const wxString kw_protected    (_T("protected"));
    const wxString kw_public       (_T("public"));
    const wxString kw_return       (_T("return"));
    const wxString kw_static       (_T("static"));
    const wxString kw_struct       (_T("struct"));
    const wxString kw_switch       (_T("switch"));
    const wxString kw_template     (_T("template"));
    const wxString kw_typedef      (_T("typedef"));
    const wxString kw_typename     (_T("typename"));
    const wxString kw_union        (_T("union"));
    const wxString kw_using        (_T("using"));
    const wxString kw_virtual      (_T("virtual"));
    const wxString kw_volatile     (_T("volatile"));
    const wxString kw_while        (_T("while"));
    const wxString opbrace         (_T("{"));
    const wxString opbracesemicolon(_T("{;"));
    const wxString clbrace         (_T("}"));
    const wxString tilde           (_T("~"));
};

--- End code ---

So, I suggest using the name "FindFunctionOpenParenthesis". :D

I just test your patch, and works flawless. great job!!!

oBFusCATed:
Ollydbg: I don't understand what you are trying to say...

I've just modified the code and tried to follow the style of the code around it...

Navigation

[0] Message Index

[#] Next page

[*] Previous page