User forums > Nightly builds
The 20 February 2011 build (7017) is out.
Jenna:
--- Quote from: jens on March 12, 2011, 11:24:18 am ---Can you test the attached patch ?
I do not have issues with it until now, but four (or more) eyes see mre than two of course.
--- End quote ---
There's a minor issue with bitmap-placing (y-value).
Can be fixed by replacing:
--- Code: --- dc.DrawBitmap(page.bitmap,
bitmap_offset,
tab_rect.y +(tab_rect.height - page.bitmap.GetHeight()) / 2,
true);
--- End code ---
with
--- Code: --- int bitmapY = tab_rect.y +(tab_rect.height - page.bitmap.GetHeight()) / 2;
if(!page.active)
bitmapY += m_Ythickness;
dc.DrawBitmap(page.bitmap,
bitmap_offset,
bitmapY,
true);
--- End code ---
oBFusCATed:
Looks better now, but there are some problems left:
(only tested with my theme):
1. Height calculations in the Log's notebook are wrong (there are 1 or 2 pixels more then needed).
2. The close button has the same problem as the text in the previous patch -> when the tab is deactivated the icon moves up instead of down. (I've applied your patch plus the change in the last post).
3. The drop list button is larger, than it should be, with my patch it is the correct size.
Screenshot showing 2 and 3: http://smrt.is-a-geek.org/codeblocks/screens/cb_gtk_tool_breakage2.png
Jenna:
--- Quote from: oBFusCATed on March 13, 2011, 12:07:06 pm ---Looks better now, but there are some problems left:
(only tested with my theme):
1. Height calculations in the Log's notebook are wrong (there are 1 or 2 pixels more then needed).
2. The close button has the same problem as the text in the previous patch -> when the tab is deactivated the icon moves up instead of down. (I've applied your patch plus the change in the last post).
3. The drop list button is larger, than it should be, with my patch it is the correct size.
Screenshot showing 2 and 3: http://smrt.is-a-geek.org/codeblocks/screens/cb_gtk_tool_breakage2.png
--- End quote ---
1. I already have seen this issue with one or two themes, but can not reproduce it now (Darkilouche from http://art.gnome.org/download/themes/gtk2/1285/GTK2-Darkilouche.tar.bz2 also works well),
2. is fixed with the attached patch,
3. is smaller now, but I did not find a real gtk-notebook with a window-list, so the size might be mre or less a mtter of taste.
The patch is against actual trunk (svn r7055).
oBFusCATed:
1. Will test with this one...
2. What patch?
3. Have you tried FF 4.0b13pre?
Edit:
1. Still broken with your version of Darkilouche. Here I'm on wxGTK 2.8.11 (from wxPython), gtk+-2.22.1-r1...
Also do you have the correct gtk engine for the theme? (I'm not sure which it is thought)
Jenna:
--- Quote from: oBFusCATed on March 13, 2011, 08:42:08 pm ---1. Will test with this one...
2. What patch?
3. Have you tried FF 4.0b13pre?
--- End quote ---
2. :oops: here it is
3. I use iceweasel (the unbranded debian-build of ff) version is rc1 at the moment, here the button has the same height than the tabs, but the arrow inside is quite small. As I wrote its matter of taste, but in ff it looks good.
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version