User forums > Nightly builds

The 20 February 2011 build (7017) is out.

<< < (6/11) > >>

Jenna:

--- Quote from: oBFusCATed on March 03, 2011, 09:57:19 am ---
--- Quote from: jens on February 26, 2011, 08:31:47 pm ---Can you try it with target->SetTabCtrlHeight(-1); commented out ?
I'm not sure if it is still needed.

--- End quote ---
Removing my patch from above and target->SetTabCtrlHeight(-1); brings the problem back :(
If I don't remove my patch and remove target->SetTabCtrlHeight(-1); it works...

--- End quote ---
Really weird, it still does not happen for me on any machine.

oBFusCATed:
I'm using wxGTK 2.8.11 (which is build from the wxPython sources), gtk+ 2.22.1.

And this patch: http://smrt.is-a-geek.org/codeblocks/patches/gtk_notebook4.patch

Jenna:

--- Quote from: oBFusCATed on March 03, 2011, 11:44:31 am ---I'm using wxGTK 2.8.11 (which is build from the wxPython sources), gtk+ 2.22.1.

And this patch: http://smrt.is-a-geek.org/codeblocks/patches/gtk_notebook4.patch

--- End quote ---
In the meantime, I get this issue also, but not always and if I get it, it happens for "Logs & others" and the "Management"-pane.
I use a modified (and enhanced) version of your gtk-notebook patch.
I still never get it without this patch.
I will set some debug-messages to find the real cause for this issue.
Your workaround works, but I like it more, if I find the real cause.

Jenna:
@oBFusCATed :
Could you please test the attached patch (if possible) ?

It moves an improved version of your gtk-notebook stuff into notebookstyles.{cpp|h} and should also fix the issue that some of the notebooks do not use the correct TabArtProvider after a start of C::B.

Improvements to the gtk-notebook stuff:
Always use the close-icon provided by gtk (switching theme now also switches close-icon),
use the foreground-color provided by gtk for active and inactive tabs,
use different height for active tabs (as gtk does it),
use a focus rectangle as gtk does it.

On some themes the "Build messages" tab might be one (or two) pixels too large (height), because the used icon has the wrong size.
If the patch will be committed, I also commit a fixed icon.

If there aren't any objections, I will commit this patch (using gtk as TabArtProvider for auinotebooks if default tab-theme is used on wxGTK systems).
This needs gtk-2.0 as build-dependency on linux.

EDIT:
I just updated the patch to fix an issue with the focus-rectangle on the rightmost tab.
If the tab is clipped, but still has the focus, the focus-rectangle was partially drawn

oBFusCATed:
OK, I'll test tonight, but I prefer the style to be in separate file.
I had an idea to show it to the wx guys, so it can be included in wxGTK, by default.
But I'm lacking the motivation to talk to them:)

Navigation

[0] Message Index

[#] Next page

[*] Previous page