Developer forums (C::B DEVELOPMENT STRICTLY!) > Plugins development

Commit 6241 candidate to be partly reverted ?

<< < (2/3) > >>

Jenna:
Here comes a simple patch, that only changes the ID, if the control is local and has no events (registered in wxSmith):


--- Code: ------ codeblocks.trunk/src/plugins/contrib/wxSmith/wxwidgets/wxscorrector.cpp
+++ codeblocks.trunk/src/plugins/contrib/wxSmith/wxwidgets/wxscorrector.cpp
@@ -207,7 +207,8 @@
         }
     }
 
-    if ( Item->GetPropertiesFlags() & flLocal )
+    if ( (Item->GetPropertiesFlags() & flLocal) &&
+         ((Item->GetEvents().GetCount()) <= 0) )
     {
         wxString prefix = s_IdPrefix;
         prefix << Item->GetInfo().DefaultVarName.Upper();

--- End code ---

This is most likley the simplest solution (but without additional configuration and therefore a little less flexibility).

MortenMacFly:

--- Quote from: jens on January 11, 2011, 09:41:26 pm ---
--- Code: ------ codeblocks.trunk/src/plugins/contrib/wxSmith/wxwidgets/wxscorrector.cpp
+++ codeblocks.trunk/src/plugins/contrib/wxSmith/wxwidgets/wxscorrector.cpp
@@ -207,7 +207,8 @@
         }
     }
 
-    if ( Item->GetPropertiesFlags() & flLocal )
+    if ( (Item->GetPropertiesFlags() & flLocal) &&
+         ((Item->GetEvents().GetCount()) <= 0) )
     {
         wxString prefix = s_IdPrefix;
         prefix << Item->GetInfo().DefaultVarName.Upper();

--- End code ---
This is most likley the simplest solution (but without additional configuration and therefore a little less flexibility).

--- End quote ---
OK, I'll try. BTW: I would like to open an wxSmith branch to allow certain other extensions for testing. I've still a couple of controls for wxSmith not yet committed. However, the build systems for these is not tested at all and probably wrong. So I'll open a branch accordingly and this would be commit there, too... OK?

Jenna:

--- Quote from: MortenMacFly on January 12, 2011, 07:03:53 am ---BTW: I would like to open an wxSmith branch to allow certain other extensions for testing. I've still a couple of controls for wxSmith not yet committed. However, the build systems for these is not tested at all and probably wrong. So I'll open a branch accordingly and this would be commit there, too... OK?

--- End quote ---

Yes !

MortenMacFly:

--- Quote from: jens on January 12, 2011, 07:24:58 am ---Yes !

--- End quote ---
branch is done, commit at will. I'll do the same whenever I find the time...

Jenna:
It's (possibly) brought up by a user again: http://forums.codeblocks.org/index.php/topic,14178.msg95264.html#msg95264

What about commiting the fix I posted some posts above.

Navigation

[0] Message Index

[#] Next page

[*] Previous page