Author Topic: Request : C::B View::notebook enhancements  (Read 83138 times)

Offline ollydbg

  • Developer
  • Lives here!
  • *****
  • Posts: 6034
  • OpenCV and Robotics
    • Chinese OpenCV forum moderator
Re: Request : C::B View::notebook enhancements
« Reply #90 on: January 27, 2011, 09:28:27 am »
One more info: I've turned on the  debug output on parserthread.cpp
Code
#define CC_PARSERTHREAD_DEBUG_OUTPUT 1
and I see lots of messages in the DebugLog panel (as expected). If I change from one tab to another before waiting for *all* messages to show up, i.e. while the logging is in progress, it freezes here, no matter what!
I'm just not sure if this is because the parser hasn't finished and that causes the freeze or it's just a display problem, that the DebugLog is flooded with messages and moving to another editor tab just cannot be treated by the painting thread... Anyway, just FYI.
This is because there are too many log message, so you will get freeze, You can disable all the "header path search" in the CC dialog, so that CC can only parse your project files.
If some piece of memory should be reused, turn them to variables (or const variables).
If some piece of operations should be reused, turn them to functions.
If they happened together, then turn them to classes.

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 13406
    • Travis build status
Re: Request : C::B View::notebook enhancements
« Reply #91 on: February 17, 2011, 10:25:25 pm »
There is another bug with the enhancement:

1. Goto the main menu
2. Open a menu that is rendered on top of the notebook
3. Hover on an item on top of the notebook

The result is that the menu closes and the tooltip shows
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline daniloz

  • Regular
  • ***
  • Posts: 268
Re: Request : C::B View::notebook enhancements
« Reply #92 on: February 17, 2011, 10:34:20 pm »
There is another bug with the enhancement:

1. Goto the main menu
2. Open a menu that is rendered on top of the notebook
3. Hover on an item on top of the notebook

The result is that the menu closes and the tooltip shows
Here, on Windows Vista 32-bit, trunk svn 7010, the menu doesn't close when the tooltip shows and I can come back to it...
However, if I do one more step:
4- after the tooltip is shown, click outside C::B

C::B crashes! :-o

Offline Jenna

  • Administrator
  • Lives here!
  • *****
  • Posts: 7252
Re: Request : C::B View::notebook enhancements
« Reply #93 on: February 17, 2011, 10:46:32 pm »
I look into it, thanks for reporting.

Offline Jenna

  • Administrator
  • Lives here!
  • *****
  • Posts: 7252
Re: Request : C::B View::notebook enhancements
« Reply #94 on: February 18, 2011, 10:08:29 am »
Could you please test svn r7011 (if needed, I can merge trunk to debugger-branch).
I was not able to reproduce the crash on windows (tested on vista 64-bit), but the tooltip should not appear any more if the tab is behind an open menu.
So the crash might also be fixed.

Offline daniloz

  • Regular
  • ***
  • Posts: 268
Re: Request : C::B View::notebook enhancements
« Reply #95 on: February 18, 2011, 10:29:08 am »
Could you please test svn r7011 (if needed, I can merge trunk to debugger-branch).
I was not able to reproduce the crash on windows (tested on vista 64-bit), but the tooltip should not appear any more if the tab is behind an open menu.
So the crash might also be fixed.
Great work!  8)
I can confirm, no more tooltip if the menu is open and, most important, no more crashes !!!

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 13406
    • Travis build status
Re: Request : C::B View::notebook enhancements
« Reply #96 on: February 18, 2011, 05:29:24 pm »
(if needed, I can merge trunk to debugger-branch).
I can test only after a merge, but don't worry, too much.

Another thing:
If I click on a tab that is not the first one, but it is not the last one either, the tab I've clicked on is made the first one.
There more tabs, than there is space on the notebook, so probably your code for scrolling is kicking in.
This behaviour is a bit annoying...
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline Jenna

  • Administrator
  • Lives here!
  • *****
  • Posts: 7252
Re: Request : C::B View::notebook enhancements
« Reply #97 on: February 18, 2011, 05:39:34 pm »
Another thing:
If I click on a tab that is not the first one, but it is not the last one either, the tab I've clicked on is made the first one.
There more tabs, than there is space on the notebook, so probably your code for scrolling is kicking in.
This behaviour is a bit annoying...

Confirmed.
Next issue to fix.

Offline Jenna

  • Administrator
  • Lives here!
  • *****
  • Posts: 7252
Re: Request : C::B View::notebook enhancements
« Reply #98 on: February 19, 2011, 04:03:30 pm »
Another thing:
If I click on a tab that is not the first one, but it is not the last one either, the tab I've clicked on is made the first one.
There more tabs, than there is space on the notebook, so probably your code for scrolling is kicking in.
This behaviour is a bit annoying...

Confirmed.
Next issue to fix.
Should be fixed in svn r7015 on trunk and svn r7016 in debugger-branch.

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 13406
    • Travis build status
Re: Request : C::B View::notebook enhancements
« Reply #99 on: February 19, 2011, 04:24:04 pm »
Testing it ... seems the two problems are fixed...

Can you implement an invert scrolling options?
I want to have the same scrolling as in Firefox, but at the moment it is in the opposite direction.
It is a little bit confusing, because I'm scrolling first to the wrong direction, then I realize it is the opposite,
so I always do two operations instead of just one.
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline Jenna

  • Administrator
  • Lives here!
  • *****
  • Posts: 7252
Re: Request : C::B View::notebook enhancements
« Reply #100 on: February 19, 2011, 05:06:05 pm »
Testing it ... seems the two problems are fixed...

Can you implement an invert scrolling options?
I want to have the same scrolling as in Firefox, but at the moment it is in the opposite direction.
It is a little bit confusing, because I'm scrolling first to the wrong direction, then I realize it is the opposite,
so I always do two operations instead of just one.
Inverse scrolling for both kinds of scrolling ?

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 13406
    • Travis build status
Re: Request : C::B View::notebook enhancements
« Reply #101 on: February 19, 2011, 05:09:59 pm »
Yes, also the scrolling of the active editor could have an option to enable/disable wrapping
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 13406
    • Travis build status
Re: Request : C::B View::notebook enhancements
« Reply #102 on: June 06, 2011, 11:55:28 pm »
Hm, I think, I've solved the tooltip steeling focus bug.
The problem seems to be in the wxWidgets, more specifically in the constructor of wxTipWindow.
Replace the line 120 in tipwnd.cpp from:
Code
           : wxPopupTransientWindow(parent)
To:
Code
           : wxPopupTransientWindow(parent, wxBORDER_NONE|wxWANTS_CHARS)

I've not talked with the wx guys, nor have I tested it thoroughly...
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline nanyu

  • Almost regular
  • **
  • Posts: 188
  • nanyu
Re: Request : C::B View::notebook enhancements
« Reply #103 on: June 07, 2011, 10:17:32 am »
I have a "half finished" work about "tab on left/right".
Is the code useful?
sorry for my english, let's see a image:

Offline Jenna

  • Administrator
  • Lives here!
  • *****
  • Posts: 7252
Re: Request : C::B View::notebook enhancements
« Reply #104 on: June 07, 2011, 05:40:41 pm »
Hm, I think, I've solved the tooltip steeling focus bug.
The problem seems to be in the wxWidgets, more specifically in the constructor of wxTipWindow.
Replace the line 120 in tipwnd.cpp from:
Code
           : wxPopupTransientWindow(parent)
To:
Code
           : wxPopupTransientWindow(parent, wxBORDER_NONE|wxWANTS_CHARS)

I've not talked with the wx guys, nor have I tested it thoroughly...
I'm not at home this week (and the next two weeks also), but I will test it theis evening in the hotel or at one of the weekends.
It would be really great  if that can fix it.