Developer forums (C::B DEVELOPMENT STRICTLY!) > CodeCompletion redesign

m_TopNameSpaces in TokensTree class seems useless

(1/2) > >>

ollydbg:
@all

When reviewing the code of token class, I found that: m_TopNameSpaces is not needed any more.

If you search the member variable "m_TopNameSpaces" usage by ThreadSearch, you will notice that no one use it.

So, shall we just delete this un-used variable?

It is declared in: token.h line 285.

ollydbg:
Also, this variable


--- Code: ---m_Modified
--- End code ---

is only used when we need to cache the tokens to hard-disk.


--- Code: ---bool Parser::CacheNeedsUpdate()
{
    if (m_UsingCache)
    {
        wxCriticalSectionLocker locker(s_TokensTreeCritical);
        return m_TokensTree->m_Modified;
    }
    return true;
}

--- End code ---

But, In-fact we don't use cache at all, so should be removed too.

MortenMacFly:

--- Quote from: ollydbg on October 21, 2010, 08:14:05 am ---But, In-fact we don't use cache at all, so should be removed too.

--- End quote ---
After a short discussion about if we need the cache at all anymore I'd say if this turns out to be of no use anymore we should rather remove the whole cache facility, not only this variable. Otherwise caching is broken.

ollydbg:
agreed.

The cache was too big(eg. the codeblocks.cbp should have 100M memory size) to save to hard disk.

So, I think we don't need cache persistent facility anymore.

MortenMacFly:

--- Quote from: ollydbg on October 21, 2010, 10:02:46 am ---The cache was too big(eg. the codeblocks.cbp should have 100M memory size) to save to hard disk.

--- End quote ---
The case wasn't saved to the project file abut another (binary based) file. So the size would not be an issue. The question is if we need this to improve speed of scanning through large projects...

Navigation

[0] Message Index

[#] Next page