Developer forums (C::B DEVELOPMENT STRICTLY!) > Plugins development
Added new image tools to wxSmith
Cryogen:
--- Quote from: MortenMacFly on September 03, 2010, 08:37:36 pm ---
--- Quote from: Cryogen on September 03, 2010, 06:56:30 am ---Cool, thanks. :-)
--- End quote ---
Ok, I tried. Here are my remarks:
The original contribution had way more image controls included, like wxImageButton, wxImageComboEditDialog, wxImageListDialog... So it seems this is only a sub-set. Why? In fact it would make things more complicated...?!
For now, I'd rather submit the original add-on instead unless you have a very good reason.
--- End quote ---
Because I wanted the image editor and the core controls in the core code, not all of the new controls, which I think are better being in a plug-in. I was going to have to do something to allow lists of images anyway and didn't want to re-invent what had already been well done. The bitmap combobox was already in wxSmith anyway, despite it being in the original plug-in, too. My intention is also to rework the plug-in to remove those components and allow the others to use the new core code.
Secondly, if the editor's in the separate plug-in, you now have to run that plug-in or wxSmith breaks. Bad karma.
Further, I just discovered today that the editenumproperty has actually been added to wxPropGrid, so I'll have to make changes to reflect that, too, I think. Need to look at it. ;-)
Ciao.
MortenMacFly:
--- Quote from: Cryogen on September 06, 2010, 04:18:27 am ---Because I wanted the image editor and the core controls in the core code, not all of the new controls, which I think are better being in a plug-in.
--- End quote ---
OK. Do you believe it would be possible to remove those parts from the original submission (the wxSmithImage plugin) so that in summary we have both functionalities again?
Cryogen:
--- Quote from: MortenMacFly on September 13, 2010, 12:04:05 pm ---
--- Quote from: Cryogen on September 06, 2010, 04:18:27 am ---Because I wanted the image editor and the core controls in the core code, not all of the new controls, which I think are better being in a plug-in.
--- End quote ---
OK. Do you believe it would be possible to remove those parts from the original submission (the wxSmithImage plugin) so that in summary we have both functionalities again?
--- End quote ---
Hey Morten,
Yes, shouldn't be a problem. Just to recap, the intention was to add to wxSmith, not import wxSmithImage, as it were. The fact the some functionality came from wxSmithImage is by-the-by (and just means it's a nice piece of work). I think you might have been looking at it as though it was a half-hearted effort to bring wxSmithImage into wxSmith. That wasn't the idea.
I have some updates done and I still need to look at whether changes should be made now that editenumproperty exists in propgrid. Perhaps by the end of the week I can have it done.
Thanks,
Gary.
MortenMacFly:
--- Quote from: Cryogen on September 14, 2010, 02:48:02 am ---Yes, shouldn't be a problem. Just to recap, [...]
I think you might have been looking at it as though it was a half-hearted effort [...]
--- End quote ---
No no... that's wasn't the problem, I just don't wanted to sacrifice all the "missing" features of that new patch for the benefit of integrating wxSmithImage into wxSmith only partially. I agree that it's worth either splitting it up into two parts (one integrated, the other as stand-alone) or just fully integrate it into the wxSmith core. However, the latter should always ensure that the controls belong to the wxWidgets core, too.
Cryogen:
--- Quote from: MortenMacFly on September 14, 2010, 01:00:00 pm ---
--- Quote from: Cryogen on September 14, 2010, 02:48:02 am ---Yes, shouldn't be a problem. Just to recap, [...]
I think you might have been looking at it as though it was a half-hearted effort [...]
--- End quote ---
No no... that's wasn't the problem, I just don't wanted to sacrifice all the "missing" features of that new patch for the benefit of integrating wxSmithImage into wxSmith only partially. I agree that it's worth either splitting it up into two parts (one integrated, the other as stand-alone) or just fully integrate it into the wxSmith core. However, the latter should always ensure that the controls belong to the wxWidgets core, too.
--- End quote ---
Yeah, see my PM today. I think we've arrived at the same conclusion. :-)
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version