Developer forums (C::B DEVELOPMENT STRICTLY!) > CodeCompletion redesign

some issues and requests

<< < (5/12) > >>

MortenMacFly:

--- Quote from: blueshake on September 02, 2010, 11:32:58 am ---
--- Quote from: killerbot on September 02, 2010, 11:10:29 am ---this is great news, if you feel confident have Martin put it on the cc branch, so we can test :-)
on to the next smart pointer  8)

--- End quote ---
done. :D

--- End quote ---
Sorry guys, I'm rather busy so I saw this just today. I've applied in to the branch, however - from my point of view this is untested, so be careful.

From a quick inspection of the code I realised at least one spelling mistake "tokenOperatroType" and method names like "CollectSS" won't really improve readability of the code. But these are probably minor things. However, I'd love to see them fixed.

killerbot:
I have tested on the original example, and all 3 smart pointers (auto/unique/shared) work marvelous.
Really great, well done  :P

ollydbg:

--- Quote from: MortenMacFly on September 02, 2010, 08:57:12 pm ---
--- Quote from: blueshake on September 02, 2010, 11:32:58 am ---
--- Quote from: killerbot on September 02, 2010, 11:10:29 am ---this is great news, if you feel confident have Martin put it on the cc branch, so we can test :-)
on to the next smart pointer  8)

--- End quote ---
done. :D

--- End quote ---
Sorry guys, I'm rather busy so I saw this just today. I've applied in to the branch, however - from my point of view this is untested, so be careful.

From a quick inspection of the code I realised at least one spelling mistake "tokenOperatroType" and method names like "CollectSS" won't really improve readability of the code. But these are probably minor things. However, I'd love to see them fixed.

--- End quote ---

the class : NativeParser is too big, and contains many mixed functionalities, I would suggest to divide to subclasses.

blueshake:

blueshake:
about the typo, and the readability,ollydbg had token over the job.let's wait for his good news. :P

Navigation

[0] Message Index

[#] Next page

[*] Previous page