Developer forums (C::B DEVELOPMENT STRICTLY!) > Development

Do we need so many tab pages in the message panel?

<< < (3/4) > >>

Jenna:
We use it to make sure the range from baseID to baseID + numPages can not be used as ID by others.

So we have a range of ID's we can associate with our tabs and recalc the tab-id from the eventID.

It might be possible to do it another way.
I will look into it.

oBFusCATed:
Yes, And this mechanism will fail if the count of pages > num_pages, which is possible at the moment.

Here is the modified patch for the debugger_branch: http://smrt.is-a-geek.org/codeblocks/patches/message_pane_order2.patch

After simple testing it seems to work...

Jenna:

--- Quote from: oBFusCATed on June 05, 2010, 02:27:52 pm ---Yes, And this mechanism will fail if the count of pages > num_pages, which is possible at the moment.

Here is the modified patch for the debugger_branch: http://smrt.is-a-geek.org/codeblocks/patches/message_pane_order2.patch

After simple testing it seems to work...

--- End quote ---
I updated the patch to get rid of the num_pages constant.
Only infopane.* have changed since the first patch, so it should be easier to merge it with the debugger-branch patch.

[attachment deleted by admin]

Jenna:
Are there any experiences (expect for this one) ?

Are there any objections against committing the patch ?

MortenMacFly:

--- Quote from: jens on July 11, 2010, 08:45:36 pm ---Are there any experiences

--- End quote ---
I've used it, too since day one, no issues here.


--- Quote from: jens on July 11, 2010, 08:45:36 pm ---Are there any objections against committing the patch ?

--- End quote ---
Not from my side.

Navigation

[0] Message Index

[#] Next page

[*] Previous page