Author Topic: Gtk Notebook  (Read 6236 times)

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 13413
    • Travis build status
Gtk Notebook
« on: April 18, 2010, 04:07:52 pm »
Hello,

I've playing with an art class for the notebook using the native gtk2.0 controls.
Here you can see a screenshot with the result:
http://smrt.is-a-geek.org/codeblocks/screens/gtk_notebook.png

And here is the patch:
http://smrt.is-a-geek.org/codeblocks/patches/gtk_notebook.patch

Please test and report problems.
If there is a gtk-2.0 guru around, a code review will be greatly appreciated.

p.s. I wasn't able to find why the logger notebook is not using the correct style/art
p.p.s. someday in the future I plan to the same for the toolbars
p.p.p.s. If you've found a problem, please name the theme you're using
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline MortenMacFly

  • Administrator
  • Lives here!
  • *****
  • Posts: 9694
Re: Gtk Notebook
« Reply #1 on: April 20, 2010, 04:57:24 pm »
http://smrt.is-a-geek.org/codeblocks/patches/gtk_notebook.patch
[...]
p.p.p.s. If you've found a problem, please name the theme you're using
Well, it breaks compilation on Windows. ;-)
You'd better wrap everything into an "#if defined(__WXGTK__)", including the header file (which cannot be found in the windows project anyways due to the missing include path).
Compiler logging: Settings->Compiler & Debugger->tab "Other"->Compiler logging="Full command line"
C::B Manual: https://www.codeblocks.org/docs/main_codeblocks_en.html
C::B FAQ: https://wiki.codeblocks.org/index.php?title=FAQ

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 13413
    • Travis build status
Re: Gtk Notebook
« Reply #2 on: April 20, 2010, 07:46:09 pm »
Uf, I forgot that... will fix....
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline foobar123

  • Multiple posting newcomer
  • *
  • Posts: 17
Re: Gtk Notebook
« Reply #3 on: April 22, 2010, 02:48:08 pm »
I like this patch! It looks good, blends in well with the rest of my desktop, and it uses the default colors for text and background, which makes it work with dark color themes, too. Would be nice to have this in default Code::Blocks some day, either replacing the default tab style, or (maybe even be better) as an additional selectable style.
Maybe a configure option could be created, so people who don't want the GTK depencendy can disable it.

Offline Jenna

  • Administrator
  • Lives here!
  • *****
  • Posts: 7255
Re: Gtk Notebook
« Reply #4 on: April 22, 2010, 03:09:35 pm »
I had some (more or less) minor layout issues with the them I use (Raleigh), but I'm forced to use windows at the moment (try to set up the control for a Natural adventure pool, and as usual it takes time until everything runs fine), so I can not look into it before the weekend.

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 13413
    • Travis build status
Re: Gtk Notebook
« Reply #5 on: April 22, 2010, 11:17:58 pm »
Jens, It works for me and looks decent, can you provide a screenshot?

Also I don't know how to extract size information the theme regarding the tab size and text/icon position :(
If anybody knows, I'll be very grateful if he/she shares this information.
« Last Edit: April 22, 2010, 11:19:44 pm by oBFusCATed »
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]