Developer forums (C::B DEVELOPMENT STRICTLY!) > CodeCompletion redesign

Rewrote the DoParse function

<< < (2/3) > >>

ollydbg:

--- Quote from: JGM on April 19, 2010, 06:52:42 pm ---I think the problem here is that english is hard for him, he needs a mediator, some one that speaks on his native language, discuss with him his work and organize the ideas here, just a suggestion  :)

Would be a shame loosing track of his work because of lack in organization (communication problems?)

--- End quote ---

I would like to help with the translation between Chinese and English.

ollydbg:
About loaden's the patch:

I found there is some code in your patch:

--- Code: ---switch (token.Length())
--- End code ---

Why do a switch statement depend on the string length??

For me, I would do something like this ( You can find this method in any books teaching about compiler design ):

The low level lexer( or Tokenizer ), the "Token" returned from the Tokenizer should have two fields:
1, token type: identifier, open brace, close brace....  and these types were categories by different enum value.
2, token value: for a "identifier" type token, the value is a wxString, just the "identifier" 's name, for open brace type token, they don't have a "token value" field.


In the parserthtread code, we can do a switch by the "token type".

Loaden:

--- Quote from: MortenMacFly on April 19, 2010, 06:28:06 pm ---Hi Loaden,
I fully respect all the work you are doing. Hence please keep in mind that we need to track all your ideas for a proper later integration. Unluckily it comes to a moment where we are in feature freeze. I am hardly trying to keep everything you are proposing but it's getting harder and harder with every patch of yours. So my request would be, can you please track everything in a way that we can have all patches in one place? Probably you can post all of them in an own thread of yours, just a short information:
- what do they do
- what do they modify
- what's the base SVN revision to apply them to
- (what other patches are required for the to apply)
- what are conflicts with other patches
- link to another place in the forums for discussions.
Inform that this thread is a collection of patches and that answers are not welcome (I can even remove discussion).
I realised that you already conflict with a patch of OllyDbg. It will be hard to resolve this in the end and I don't want to take such a risk later on.

--- End quote ---
OK, I will do it in the next two days.

Loaden:

--- Quote from: ollydbg on April 20, 2010, 01:48:27 am ---
--- Quote from: JGM on April 19, 2010, 06:52:42 pm ---I think the problem here is that english is hard for him, he needs a mediator, some one that speaks on his native language, discuss with him his work and organize the ideas here, just a suggestion  :)

Would be a shame loosing track of his work because of lack in organization (communication problems?)

--- End quote ---

I would like to help with the translation between Chinese and English.

--- End quote ---
Thanks lot!

MortenMacFly:

--- Quote from: Loaden on April 19, 2010, 03:55:55 pm ---And now, the DoParse function like this:

--- End quote ---
Ok, I had a look. Besides a clearer look, what I saw in the first place is a GoTo. This is unfortunately a "no-go" for us. Please don't use GoTos in C++. This is very bad style and there is no reason for doing this.

Navigation

[0] Message Index

[#] Next page

[*] Previous page