Developer forums (C::B DEVELOPMENT STRICTLY!) > Plugins development

wxSmith improvement

<< < (9/12) > >>

Jenna:

--- Quote from: MortenMacFly on September 03, 2010, 08:34:01 pm ---
--- Quote from: jens on September 03, 2010, 08:13:10 pm ---It slipped with the wxPropgrid update (svn r6339) and not with your patches.

--- End quote ---
Could you try again, please. By accident the 1.4'er version chosen to use had a serious bug. :-(

--- End quote ---
Does not fix it  :(

Cryogen:

--- Quote from: PaulS on September 03, 2010, 09:52:50 pm ---You asked if I was using the August 24 nightly, No I'm using August 30th svn 6562.  However, I must recant.  The problem is probably my own doing.

On my primary machine it fails as I reported on 6562 and works fine after reinstalling 10.5 release (not sure what that svn was).
This afternoon I updated a second machine to 6562 and that one works just fine.  Put 6562 back on the primary machine & it still fails. 

Both machines are Thinkpads running Windows 7 with all the latest Microsoft updates.  They are different models and have different screen resolutions and different video components.

All files in the Codeblocks directory have the same dates. The shared subdirectory is too big to check manually.  I will look for a tool to compare directories of non-text files but don't know of one off hand.

If no one else is seeing this problem (junk in display when adding a event handler) don't waste your time.  If someone else is please speak up.

--- End quote ---

Thanks for the details, Paul. No-one is reporting it so far.
WinMerge will do what you want and is free and excellent.

Ciao.

Cryogen:

--- Quote from: jens on September 03, 2010, 10:00:57 pm ---
--- Quote from: MortenMacFly on September 03, 2010, 08:34:01 pm ---
--- Quote from: jens on September 03, 2010, 08:13:10 pm ---It slipped with the wxPropgrid update (svn r6339) and not with your patches.

--- End quote ---
Could you try again, please. By accident the 1.4'er version chosen to use had a serious bug. :-(

--- End quote ---
Does not fix it  :(

--- End quote ---

Yeah, agreed. Morten's latest commit didn't change things. My investigation so far shows that it happened with SVN6339, as Jens said. Going back to 6219, the previous change for wxSmith, everything works. I've only looked into wxsColourProperty so far. If you change the code in wxsColourProperty::PGCreate() in wxscolourproperty.cpp. lines 506/507 to reactivate wxSystemColourProperty instead of wxsMyColourPropertyClass, the error doesn't occur so it's in wxsMyColourPropertyClass. So far I haven't been able to trace it.

Cheers.

Cryogen:

 I have to say that I'm stumped with this at the moment. If anyone has more experience with the inner workings of it they would probably do better than me. It gets very convoluted with macros and there's such a lot of code that it's not easy to know exactly what's happening where, at times. I can think of two general possibilities. One is that some of the changes made when propgrid 1.4 was introduced caused the problems. The other, which seems more likely, is that the behaviour of propgrid changed and it wasn't picked up. I can't see where the problems lie at this stage.

Cheers.

Jenna:
It's most likely the second one, itmight be related to wxPGId (used in wxsXXX::PGCreate) and wxPGPropArg in newer wxPropgrid, but the depth of wxSmith and wxPropGrid is somewhat unclear to me.
Maybe I find the time to investigate more the next days.

Navigation

[0] Message Index

[#] Next page

[*] Previous page

Go to full version