User forums > General (but related to Code::Blocks)

What's editor for CB's xrc resource?

<< < (3/3)

ollydbg:

--- Quote from: ollydbg on August 27, 2012, 05:58:32 am ---Under Windows, wxsmith works quite nicely with the xrc file which has CR LF  EOL format...

--- End quote ---
The only issue here is that the original xrc file such as "src/sdk/resources/editor_configuration.xrc" use 4 spaces as indentation, after editing by wxsmith, the indentation was changed to use "tab". Any comments about this? I think "tab" are normally good for xml files, see, our codeblocks.cbp file use "tab" for indentation. When create a new wx sample project from the wizard, the wxs file also use "tab" as indentation.


--- Quote from: oBFusCATed on August 27, 2012, 09:27:03 am ---
--- Quote from: ollydbg on August 27, 2012, 05:58:32 am ---To reproduce this, you can just convert the original xrc to LF EOL format under Windows, then change the UI under wxsmtih, then compared the result with the original one.

--- End quote ---
If you see LF or LF/CR LF files then they are broken and should be fixed.

See this: http://magic.aladdin.cs.cmu.edu/2006/03/01/end-of-line-conversion-in-subversion/
See this for a how-to about fixing broken files: http://stackoverflow.com/questions/8024740/whats-the-best-way-to-have-svneol-style-native-for-text-files-by-defaultsvn

--- End quote ---
Thanks, my issue is that I'm using git, and I clone the c::b git, but I does not enabled the auto LF to CRLF conversion under MsysGit, so I'm dealing with the LF sources(h/cpp), and LF xrc files in the git local copy.

If I'm under SVN(TortoiseSVN), I don't have the EOL issue, because I have CRLF sources and xrc files.

MortenMacFly:

--- Quote from: ollydbg on August 27, 2012, 10:39:51 am ---The only issue here is that the original xrc file such as "src/sdk/resources/editor_configuration.xrc" use 4 spaces as indentation, after editing by wxsmith, the indentation was changed to use "tab". Any comments about this?

--- End quote ---
I think its OK to respect the editor settings for (text based) resource, files, too. That's how its implemented. So when editing a resource  file with wxSmith and having "spaces" as editor option this is the expected result. If this works differently, it is a bug (as you mentioned in the other thread, probably...) For patches, IMHO you have an opton to ignore white-space changes... at least I have. :) That solves the issue with having too many changes on XRC files.

Navigation

[0] Message Index

[*] Previous page