Developer forums (C::B DEVELOPMENT STRICTLY!) > CodeCompletion redesign

Weird crash - CC

<< < (3/3)

Loaden:

--- Quote from: oBFusCATed on December 14, 2010, 09:27:33 am ---
--- Quote from: Loaden on December 14, 2010, 09:22:15 am ---This is an endloop in wx.

--- End quote ---
You mean infinite loop?

--- End quote ---
Yes, It's infinite loop.

Loaden:
This patch can fix this issue, but I do not know if there is any side effects.

--- Code: ---Index: src/msw/treectrl.cpp
===================================================================
--- src/msw/treectrl.cpp (revision 66360)
+++ src/msw/treectrl.cpp (working copy)
@@ -1770,15 +1770,6 @@
     tvItem.state = 0;
     DoSetItem(&tvItem);
 
-    if ( IsExpanded(item) )
-    {
-        wxTreeEvent event(wxEVT_COMMAND_TREE_ITEM_COLLAPSING,
-                          this, wxTreeItemId(item));
-
-        if ( !IsTreeEventAllowed(event) )
-            return;
-    }
-
     if ( TreeView_Expand(GetHwnd(), HITEM(item), flag) )
     {
         if ( IsExpanded(item) )

--- End code ---

MortenMacFly:

--- Quote from: Loaden on December 14, 2010, 09:22:15 am ---OnTreeItemCollapsing -> CollapseAndReset -> IsTreeEventAllowed -> HandleTreeEvent -> OnTreeItemCollapsing  ...

--- End quote ---
If that is the case, you should definitely report this to the WX guys.

Loaden:

--- Quote from: MortenMacFly on December 14, 2010, 09:49:57 am ---
--- Quote from: Loaden on December 14, 2010, 09:22:15 am ---OnTreeItemCollapsing -> CollapseAndReset -> IsTreeEventAllowed -> HandleTreeEvent -> OnTreeItemCollapsing  ...

--- End quote ---
If that is the case, you should definitely report this to the WX guys.

--- End quote ---
done. :)
http://trac.wxwidgets.org/ticket/12774

Biplab:

--- Quote from: Loaden on December 14, 2010, 09:54:34 am ---
--- Quote from: MortenMacFly on December 14, 2010, 09:49:57 am ---
--- Quote from: Loaden on December 14, 2010, 09:22:15 am ---OnTreeItemCollapsing -> CollapseAndReset -> IsTreeEventAllowed -> HandleTreeEvent -> OnTreeItemCollapsing  ...

--- End quote ---
If that is the case, you should definitely report this to the WX guys.

--- End quote ---
done. :)
http://trac.wxwidgets.org/ticket/12774

--- End quote ---

Great Job! :)

I'll test over the weekend (or earlier if I can find time) and post feedback.

Navigation

[0] Message Index

[*] Previous page