Developer forums (C::B DEVELOPMENT STRICTLY!) > Development
Rev 6104 breaks build with wx-2.9
Jenna:
I attach a patch that works for me on debian 64-bit with self-compiled wx2.9.
There are some more fixes, I needed to make it compile the sources.
I did not (yet) change anything in contrib-plugins workspace.
wx2.9 has the whole scrollingdialog-abilities in wxDialogBase, but it is disbaled by default.
The patch only subclasses wxDialog (as suggested by Biplab) and switches layout adaptation on.
I do not get the id of e.g. wxCheckBoxes with XRCID and therfore any attempt to open for example the editor configuration dialog leads to a crash.
Is that a problem with my build of wxWidgets 2.9 or does that also happen to you (on windows).
Nevertheless please test the patch and post your feedback.
[attachment deleted by admin]
Biplab:
--- Quote from: jens on January 31, 2010, 12:02:21 am ---I attach a patch that works for me on debian 64-bit with self-compiled wx2.9.
There are some more fixes, I needed to make it compile the sources.
I did not (yet) change anything in contrib-plugins workspace.
wx2.9 has the whole scrollingdialog-abilities in wxDialogBase, but it is disbaled by default.
The patch only subclasses wxDialog (as suggested by Biplab) and switches layout adaptation on.
--- End quote ---
The patch works well. Thanks for the patch. Please commit it to trunk.
--- Quote from: jens on January 31, 2010, 12:02:21 am ---I do not get the id of e.g. wxCheckBoxes with XRCID and therfore any attempt to open for example the editor configuration dialog leads to a crash.
Is that a problem with my build of wxWidgets 2.9 or does that also happen to you (on windows).
Nevertheless please test the patch and post your feedback.
--- End quote ---
Same here. It crashes on Windows, too. If you follow my Win-64-bit thread, I've mentioned about this crash.
Jenna:
--- Quote from: Biplab on January 31, 2010, 05:10:44 am ---Same here. It crashes on Windows, too. If you follow my Win-64-bit thread, I've mentioned about this crash.
--- End quote ---
Good to hear (that it's not my error).
If I do not find a sloution in the docu or the web I will create a debug-build of wx2.9 and look into it.
The funny thing is, that it does not happen with all classes, the ID of the wxStaticText at the beginning of the editor configuration dialog seems to be determined correctly.
I will commit it after I tested it with wx2.8.
Jenna:
I found two causes for the crash, one can simply be fixed, the other one is definitely a wxWidgets bug.
If a dimension of wxFledgridSizer is not set correctly (too large or too small) it (or it's contents will not be read correctly by the xrc-loader.
changing all dynamic dimensions to 0 (or the correct value) makes it work again.
I personally prefer 0, because it's used by wxWidgets for dynamically dimensions. So we will not get trouble if components are added or removed.
The other crash is cause by a bug in wxListbook.
I filed a bug-report (with a simple patch) to the wxWidgets bug-tracker:
http://trac.wxwidgets.org/ticket/11698 .
EDIT:
I just committed a corrected version of the editorconf-xrc.
For the second crash-cause you have to patch wxWidgets or wait for an upstream fix.
Biplab:
--- Quote from: jens on February 05, 2010, 02:08:45 pm ---I found two causes for the crash, one can simply be fixed, the other one is definitely a wxWidgets bug.
If a dimension of wxFledgridSizer is not set correctly (too large or too small) it (or it's contents will not be read correctly by the xrc-loader.
changing all dynamic dimensions to 0 (or the correct value) makes it work again.
I personally prefer 0, because it's used by wxWidgets for dynamically dimensions. So we will not get trouble if components are added or removed.
The other crash is cause by a bug in wxListbook.
I filed a bug-report (with a simple patch) to the wxWidgets bug-tracker:
http://trac.wxwidgets.org/ticket/11698 .
EDIT:
I just committed a corrected version of the editorconf-xrc.
For the second crash-cause you have to patch wxWidgets or wait for an upstream fix.
--- End quote ---
I've not got time to check it. However thanks for the fix. :)
Navigation
[0] Message Index
[*] Previous page
Go to full version