Developer forums (C::B DEVELOPMENT STRICTLY!) > CodeCompletion redesign

vector<int> is OK, but string or wstring no-work.

<< < (4/23) > >>

MortenMacFly:

--- Quote from: ollydbg on January 06, 2010, 03:06:06 pm ---But for the long run, I think add a state is convient :D

--- End quote ---
I know, that's why I applied the patch. ;-) However, there seems to be something wrong with the new implementation where you surely can help... :P

ollydbg:
I'm confused about your discussion. Does this bug comes from the "real-time CC" or the patch of my modification of Tokenizer??? :?

MortenMacFly:

--- Quote from: ollydbg on January 07, 2010, 01:13:12 pm ---Does this bug comes from the "real-time CC" or the patch of my modification of Tokenizer??? :?

--- End quote ---
From the new Tokenizer states. Have another look at my previous post. The two examples in the code do obviously the opposite of what was done previously. Is this intended behaviour of yours?

Meaning, shouldn't we apply this patch:

--- Code: ---Index: src/plugins/codecompletion/parser/parserthread.cpp
===================================================================
--- src/plugins/codecompletion/parser/parserthread.cpp (revision 6058)
+++ src/plugins/codecompletion/parser/parserthread.cpp (working copy)
@@ -403,7 +403,7 @@
     // need to reset tokenizer's behavior
     // don't forget to reset that if you add any early exit condition!
     TokenizerState oldState = m_Tokenizer.GetState();
-    m_Tokenizer.SetState(tsSkipUnWanted);
+    m_Tokenizer.SetState(tsSkipNone);
 
     m_Str.Clear();
     m_LastToken.Clear();
@@ -1385,7 +1385,7 @@
         wxString next = m_Tokenizer.PeekToken(); // named namespace
         if (next==ParserConsts::opbrace)
         {
-            m_Tokenizer.SetState(tsSkipNone);
+            m_Tokenizer.SetState(tsSkipUnWanted);
 
             // use the existing copy (if any)
             Token* newToken = TokenExists(ns, m_pLastParent, tkNamespace);

--- End code ---

However, you changes quite a lot related to skipping so I might be wrong...

ollydbg:
No, the first place when entering the DoParse function. we should set the state to "


--- Code: ---    // need to reset tokenizer's behavior
    // don't forget to reset that if you add any early exit condition!
    TokenizerState oldState = m_Tokenizer.GetState();
    m_Tokenizer.SetState(tsSkipUnWanted);
    m_Str.Clear();
    ....

--- End code ---

This is the default setting.

MortenMacFly:

--- Quote from: ollydbg on January 07, 2010, 02:08:26 pm ---No, the first place when entering the DoParse function. we should set the state to "

--- End quote ---
Could you explain '' a little more? Set to what exactly? And what's with the second one?

Navigation

[0] Message Index

[#] Next page

[*] Previous page