Developer forums (C::B DEVELOPMENT STRICTLY!) > CodeCompletion redesign
CC fail after A class's static method called.
MortenMacFly:
--- Quote from: jens on December 14, 2009, 08:02:18 pm ---I took nanyu's example from the first post.
--- End quote ---
Alright... :?
I did not scroll to the end of the text box and always just copied the upper part (excluding the actual main function). My fault. Now that I can reproduce I realised the following while debugging:
With the static method call look what the buffer looks like:
ParseLocalBlock() Block:
oo;
int main()
{
A::Test(); //remove this line, then cc work well.
globalSoo.a = 9; //cc allways do work well here
Soo localeSoo;
localeSoo.
Without the static method call it looks like this:
ParseLocalBlock() Block:
globalSoo.a = 9; //cc allways do work well here
Soo localeSoo;
localeSoo.
...digging into it...
MortenMacFly:
--- Quote from: MortenMacFly on December 15, 2009, 07:09:06 am ---...digging into it...
--- End quote ---
Here is the problem:
GetQueueAsNamespaceString()
returns "A::" which is wrong.
Who implemented this method??? :lol:
I am committing some more debug stuff later today... so you can try yourself once setting PARSERTHREAD_DEBUG_OUTPUT to 1 while compiling.
ollydbg:
In the function AI().
The "global search scope" should added for every code completion session.
--- Code: --- // always add scope -1 (i.e. global namespace)
search_scope->insert(-1);
// find all other matches
std::queue<ParserComponent> components;
BreakUpComponents(parser, actual, components);
m_LastAISearchWasGlobal = components.size() <= 1;
if (!components.empty())
m_LastAIGlobalSearch = components.front().component;
// actually find all matches in selected namespaces
for (TokenIdxSet::iterator it = search_scope->begin(); it != search_scope->end(); ++it)
{
if (s_DebugSmartSense)
{
Token* scopeToken = tree->at(*it);
Manager::Get()->GetLogManager()->DebugLog(F(_T("AI() Parent scope: '%s' (%d)"),
scopeToken ? scopeToken->m_Name.wx_str() : _T("Global namespace"),
*it));
}
FindAIMatches(parser, components, result, *it, noPartialMatch, caseSensitive, true, 0xffff, search_scope);
}
// if(result.size()<1)//find nothing in the search_scope, add global namespace
// {
// if (s_DebugSmartSense)
// {
// Manager::Get()->GetLogManager()->DebugLog(F(_T("AI() result is zero, so, add the Global namespace")));
//
// }
// search_scope->insert(-1);
// FindAIMatches(parser, components, result, -1, noPartialMatch, caseSensitive, true, 0xffff, search_scope);
// }
--- End code ---
For example
--- Code: ---int aaaa;
main(){
int aaaa;
// do code completion here.
}
both the global aaaa and auto variable aaaa should be matched.
--- End code ---
ollydbg:
Here is the test code:
--- Code: ---class A
{
public:
static void Test()
{
}
};
struct Soo
{
int aaaa;
};
Soo globalSoo;
int main()
{
A::Test(); //remove this line, then cc work well.
globalSoo.aaaa = 9; //cc allways do work well here
Soo localeSoo;
localeSoo.; // <-- cc do nothing
return 0;
}
--- End code ---
and the log output of auto code completion after entering the "dot" after "localeSoo"
--- Code: ---MarkItemsByAI()
ParseUsingNamespace() Parse file scope for "using namespace"
ParseFunctionArguments() Parse function arguments
FindCurrentFunctionStart() Cached namespace='', cached proc='main'
GenerateResultSet() search 'main', parent='Global namespace (id:0, type:(null)), isPrefix=0'
ParseFunctionArguments() + Function match: main
ParseLocalBlock() Parse local block
FindCurrentFunctionStart() Cached namespace='', cached proc='main'
Parse() : parsing
DoParse() : Loop:m_Str='', token='A'
DoParse() : Loop:m_Str='', token='Test'
DoParse() : Loop:m_Str='', token='()'
DoParse() : Loop:m_Str='', token=';'
DoParse() : Loop:m_Str='', token='globalSoo'
DoParse() : Loop:m_Str='globalSoo ', token='.'
DoParse() : Loop:m_Str='', token='Soo'
DoParse() : Loop:m_Str='Soo ', token='localeSoo'
DoAddToken() : Created token='localeSoo', file_idx=0, line=6
GetActualTokenType() : Searching within m_Str='Soo'
GetActualTokenType() : Compensated m_Str='Soo'
GetActualTokenType() : Found 'Soo'
DoAddToken() : Prepending 'A::'
DoAddToken() : Added/updated token 'localeSoo' (6), type 'Soo', actual 'A::Soo'. Parent is (-1)
DoParse() : Loop:m_Str='Soo', token=';'
DoParse() : Loop:m_Str='', token='localeSoo'
DoParse() : Loop:m_Str='localeSoo ', token='.'
ParseLocalBlock() Block:
A::Test(); //remove this line, then cc work well.
globalSoo.aaaa = 9; //cc allways do work well here
Soo localeSoo;
localeSoo.
ParseLocalBlock() Local tokens:
ParseLocalBlock() + Soo localeSoo parent =
AI() AI enter, actual: " localeSoo."
AI() =========================================================
AI() Doing AI for ' localeSoo.':
FindCurrentFunctionStart() Cached namespace='', cached proc='main'
GenerateResultSet() search 'main', parent='Global namespace (id:0, type:(null)), isPrefix=0'
AI() Adding search namespace: Global namespace
BreakUpComponents() Breaking up ' localeSoo.'
BreakUpComponents() Found component: 'localeSoo' (Class)
BreakUpComponents() Found component: '' (SearchText)
AI() Parent scope: 'Global namespace' (-1)
FindAIMatches() ----- FindAIMatches - enter -----
FindAIMatches() Search for localeSoo, isLast = 0
FindAIMatches() Looping 1 results
FindAIMatches() Match: 'localeSoo' (ID='6') : type='A::Soo'
BreakUpComponents() Breaking up 'A::Soo'
BreakUpComponents() Found component: 'A' (Namespace)
BreakUpComponents() Found component: 'Soo' (SearchText)
FindAIMatches() Looking for type: 'A::Soo' (2 components)
FindAIMatches() Now looking under 'Global namespace'
FindAIMatches() ----- FindAIMatches - enter -----
FindAIMatches() Search for A, isLast = 0
FindAIMatches() Looping 1 results
FindAIMatches() Match: 'A' (ID='5') : type=''
FindAIMatches() ----- FindAIMatches - enter -----
FindAIMatches() Search for Soo, isLast = 1
FindAIMatches() Looping 0 results
FindAIMatches() ----- FindAIMatches - leave -----
FindAIMatches() ----- FindAIMatches - leave -----
FindAIMatches() No types matched 'A::Soo'.
FindAIMatches() ----- FindAIMatches - enter -----
FindAIMatches() Search for , isLast = 1
FindAIMatches() Looping 0 results
FindAIMatches() ----- FindAIMatches - leave -----
FindAIMatches() ----- FindAIMatches - leave -----
AI() AI leave, returned 0 results
0 results
--- End code ---
Note:
DoAddToken() : Added/updated token 'localeSoo' (6), type 'Soo', actual 'A::Soo'. Parent is (-1)
This is totally wrong!! I'm trying to find the error......
ollydbg:
In the DoParse function.
--- Code: --- else if (peek==ParserConsts::dcolon)
{
if (m_Str.IsEmpty())
m_EncounteredTypeNamespaces.push(token); // it's a type's namespace
else
m_EncounteredNamespaces.push(token);
m_Tokenizer.GetToken(); // eat ::
}
--- End code ---
So, for these statement:
--- Code: ---
A::Test(); //remove this line, then cc work well.
globalSoo.aaaa = 9; //cc allways do work well here
Soo localeSoo;
localeSoo.; // <-- cc do nothing
--- End code ---
A is pushed as a "typed namespace", this is wrong.
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version