Developer forums (C::B DEVELOPMENT STRICTLY!) > Plugins development
Editor Tweaks plugin
Alpha:
--- Quote from: MortenMacFly on November 25, 2012, 07:56:40 pm ---Thats just because you used recent nightlies where it was on by default. If you have a fresh installation, its off by default and won't harm unless you turn it on.
--- End quote ---
Um... this feature is on by default. I wrote it with a default 4 line buffer because that is what I personally found most useful. However, from the sounds of various recent posts, this behavior is rather unexpected. Would it be preferred if the default setting is a 1 line buffer (so the feature is still discoverable, but acts very conservatively, so it should not be too bothersome). Or should it be off by default? Or are there some other "4 line buffer supporters" out there who are remaining silent :)?
--- Quote from: Kalith on November 25, 2012, 07:53:34 pm ---[...] This is very confusing... But maybe this is intended behavior ?
--- End quote ---
Intended, yes (well, sort of), but confusing, it seems also yes :-\.
It only scrolls one line at a time so a user's eyes do not (potentially) have to jump a great distance. Unfortunately, this currently means 1 keypress == 1 line.
I have an idea for a smooth scroll to position, which would prevent the confusion of multiple scrolls when typing on the same line, but I do not know if this will make it into into the current release. If the developers think it will be faster to just reduce the default setting, I would not want to delay this release with another patch.
Alpha:
Patch 3379 for smooth scroll is available, but no pressure to review it for this release.
MortenMacFly:
--- Quote from: Alpha on November 26, 2012, 12:09:36 am ---Um... this feature is on by default. I wrote it with a default 4 line buffer because that is what I personally found most useful.
--- End quote ---
As always: Magic needs to be turned off by default. Standard (expected) behaviour is what should be enabled.
But didn't I change the default to be off in the commit?
Alpha:
Magic down:
--- Code: ---Index: src/plugins/contrib/EditorTweaks/EditorTweaksConfDlg.cpp
===================================================================
--- src/plugins/contrib/EditorTweaks/EditorTweaksConfDlg.cpp (revision 8624)
+++ src/plugins/contrib/EditorTweaks/EditorTweaksConfDlg.cpp (working copy)
@@ -26,7 +26,7 @@
int maxSavedAlignerEntries = cfg->ReadInt(_T("/aligner/max_saved_entries"),4);
SpinCtrl1->SetValue(maxSavedAlignerEntries);
- Choice1->SetSelection(cfg->ReadInt(wxT("/buffer_caret"), 4));
+ Choice1->SetSelection(cfg->ReadInt(wxT("/buffer_caret"), 1));
}
EditorTweaksConfDlg::~EditorTweaksConfDlg()
@@ -44,7 +44,7 @@
if(oldSavedAlignerEntries != newSavedAlignerEntries )
cfg->Write(_T("aligner/max_saved_entries"),newSavedAlignerEntries);
- const int oldBuffer = cfg->ReadInt(wxT("/buffer_caret"), 4);
+ const int oldBuffer = cfg->ReadInt(wxT("/buffer_caret"), 1);
const int newBuffer = Choice1->GetSelection();
if (oldBuffer != newBuffer)
cfg->Write(wxT("/buffer_caret"), newBuffer);
Index: src/plugins/contrib/EditorTweaks/EditorTweaks.cpp
===================================================================
--- src/plugins/contrib/EditorTweaks/EditorTweaks.cpp (revision 8624)
+++ src/plugins/contrib/EditorTweaks/EditorTweaks.cpp (working copy)
@@ -1184,7 +1184,7 @@
void EditorTweaks::DoBufferEditorPos(int delta)
{
if (m_buffer_caret == -1)
- m_buffer_caret = Manager::Get()->GetConfigManager(wxT("EditorTweaks"))->ReadInt(wxT("/buffer_caret"), 4);
+ m_buffer_caret = Manager::Get()->GetConfigManager(wxT("EditorTweaks"))->ReadInt(wxT("/buffer_caret"), 1);
if (m_buffer_caret < 1) // feature disabled (selected "None" in settings)
return;
cbEditor* ed = Manager::Get()->GetEditorManager()->GetBuiltinActiveEditor();
--- End code ---
MortenMacFly:
--- Quote from: Alpha on November 26, 2012, 09:32:16 pm ---Magic down:
--- End quote ---
It was really by default at 4? Well this is going to be fun with the release then... 8)
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version