Developer forums (C::B DEVELOPMENT STRICTLY!) > Development

Compiler settings issue

(1/4) > >>

killerbot:
Since the addition of the 'Compiler output to be ignored' not everything fits anymore on the dialog (at least no longer on my laptop). Not all fields related to this addition are visible, but the advanced options/settings button is also no longer visible :-(

So part of the dialog is visible together with the cancel/ok buttons;

Jenna:
I think we should discuss the usage of wxScrollingdialog (or something similar) again.
See http://forums.codeblocks.org/index.php/topic,10124.0.html.

A complete change of the settings dialogs layout was also discussed there, but I'm not sure if something like this can be done in the next time.
Or is anybody seriously working on this.

I attach a patch against current trunk (r5862) that uses wxScrolingdialog instead of wxDialog in the most places (most likely more than absolutely ecause we also have some really small dialogs).
I did not touch anything in wxsmith and wxsmithcontribitems, to avoid breaking anything.


--- Quote from: jens on February 23, 2009, 07:29:41 am ---
--- Quote from: MortenMacFly on February 23, 2009, 07:16:35 am ---
--- Quote from: jens on February 23, 2009, 01:00:27 am ---wxs- and xrc-files are left originally, because otherwise the xml-loader crashes and wxSmith can no longer read the files. [...]

--- End quote ---
...although this is a serious show-stopper to me. We should really think about whether the benefits are worth that costs. For me this drawback makes it quite useless (unfortunately). I would vote for leaving it as a proof-of-concept in the patch tracker.

...or do you (all devs) seriously thinking to apply this into trunk?

--- End quote ---

The xrc-files are no problem.
They get loaded as normally, and can be used as before, even if the loaded dialog is inherited from wxScrollingDialog (otherwise the most of our dialogs would fail).
I left them untouched, because the xml-loader don't know wxScrollingDialog and can not load the resources correctly.

The only real problem is with wxSmith, because it directly changes the source and headerfiles, and every change (to use wxScrollingialog) will be changed back to wxDialog.

--- End quote ---

I think it should be possible to add wxScrollingdialog to the wxSmithContribItems, so it can be used with wxSmith also, still not with the xrc-loader (without patching it), but this should not be a problem as written before.

EDIT:

I forgot the patch, here it is:

[attachment deleted by admin]

ollydbg:
I personally support using wxScrollingdialog. I have already applied this patch in my working copy for several months. Works quite well!

MortenMacFly:

--- Quote from: jens on October 11, 2009, 10:28:34 pm ---I think we should discuss the usage of wxScrollingdialog (or something similar) again.
[...]
I forgot the patch, here it is:

--- End quote ---
For the record: I tried on Windows and it does no harm  so far.

I'd vote to apply it in the scintilla and debugger branch as a first step as these branches are used by several people. If it works we can merge only these modifications them into trunk. Alternatively an own branch may make sense, but please based on either the scintilla or (preferable) the debugger branch so that people will use it. Hence I believe this will not be used by as many people as the existing branches.

killerbot:
great, I would say : apply in the special development branches, and bring it rather soon back to trunk, since now on certain machines things are broken, in the way, one can not access all fields, or even reach the ok button.

Navigation

[0] Message Index

[#] Next page