Developer forums (C::B DEVELOPMENT STRICTLY!) > Plugins development
SpellChecker plugin
MortenMacFly:
--- Quote from: danselmi on October 26, 2010, 01:02:30 pm ---Do you mean the AnnoyingDialog? Does it ask even after you told it to "Don't Annoy me again!"?
--- End quote ---
Yes I mean that. And no: It does not ask anymore. However, as not having the index file does not limit the functionality I believe this dialog should not show up every time. Sure thing that the other two files are required and setup correctly. My point is, that for some dictionaries you don't get the index files. So the dialog would impose you did something wrong which isn't the case.
MortenMacFly:
...wait! I had a look at the code: You seem to always show this dialog, no matter if the settings are OK or not. Is that right? I think in that case you really should check if the user needs to be informed - that's only the case when the settings are incorrect. Otherwise this will surely lead to confusion (as in my case... ;-)).
danselmi:
--- Quote from: MortenMacFly on October 26, 2010, 09:23:54 pm ---...wait! I had a look at the code: You seem to always show this dialog, no matter if the settings are OK or not. Is that right? I think in that case you really should check if the user needs to be informed - that's only the case when the settings are incorrect. Otherwise this will surely lead to confusion (as in my case... ;-)).
--- End quote ---
So, I added a check if dictionaries are present and the dialog wil not be shown then.
MortenMacFly:
--- Quote from: danselmi on October 26, 2010, 10:59:16 pm ---So, I added a check if dictionaries are present and the dialog wil not be shown then.
--- End quote ---
Aaaah! Nice. :-) :)
Guess it's time to move it into the main repo I'd say. Didn't killerbot wanted to take care of it? Any comments/thoughts?
killerbot:
I will/can take care of it ;-)
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version