Developer forums (C::B DEVELOPMENT STRICTLY!) > Development

Improvement in TabSwitcher

<< < (3/10) > >>

MortenMacFly:

--- Quote from: Feneck91 on January 12, 2010, 09:55:29 am ---What shall we do ?

--- End quote ---
I'd vote for 3>.

I've modified the patch again to make re-use of duplicate code and format it a bit. (BTW: I absolutely don't like initialisation of variables in the for () block btw...). The state of the patch in "pending" (being processed). The reason is simple: Its untested under Linux. Once this is done it may make it into trunk. That's very likely from my point of view hence the other devs can object.

Jenna:
I vote for keeping the Ctrl + Tab behaviour as it is by default and change it only if the user wants it.

Two causes for this:

1. changing an existing behaviour is normally not a good idea and can confuse other users and will most likely lead to "bug"-reports,

2. the default for Ctrl+[Shift+]Tab in most applications is to switch between the tabs directly and not to switch between the tabs accessed as last.

@Martin: it would be nice, if you can send me your cleaned up patch to test it on linux.

Feneck91:
I agree with jens, I think, let the user take the decision of way of changing documents by pressing CTRL + TAB.
It was why I propose the second patch.

--- Quote ---2. the default for Ctrl+[Shift+]Tab in most applications is to switch between the tabs directly and not to switch between the tabs accessed as last.
--- End quote ---
Not true, Visual C++ / Netbeans work like this, last accessed, first on tab order...

--- Quote ---@Martin: it would be nice, if you can send me your cleaned up patch to test it on linux.
--- End quote ---
I have modified the source code to be more understanding, if you have patched this source, please post the new version.

Thanks.

Nb : Some problems could occurs with the function void MainFrame::CreateMenubar()

--- Quote ---    // Ctrl+Tab workaround for non windows platforms:
    if ((platform::carbon) || (platform::gtk))
    {
        // Find the menu item for tab switching:
        tmpidx = mbar->FindMenu(_("&View"));
        if (tmpidx != wxNOT_FOUND)
        {
            wxMenu* view = mbar->GetMenu(tmpidx);
            wxMenuItem* switch_item = view->FindItem(idViewSwitchTabs);
            if (switch_item)
            {
                // Change the accelerator for this menu item:
                wxString accel;
                if (platform::carbon)
                    accel = wxT("Alt+Tab");
                else if (platform::gtk)
                    accel = wxT("Ctrl+,");
                switch_item->SetItemLabel(wxString(_("S&witch Tabs")) + wxT("\t") + accel);
            }
        }
    }

--- End quote ---
What shall we do here ? Testing on wich switching tab type the accel is for and modify it and only it ? Or let it like this and accelerators will overwrite it if the shortcut is modified ?

Thanks for your reply.

Alatar:

--- Quote from: Feneck91 on January 12, 2010, 09:15:36 am ---Alastar, are you agree to work together ?
I let you test my patch and accept or refuse it.

--- End quote ---
Agree of course. I try to help with further improvement patch.

--- Quote from: MortenMacFly on January 12, 2010, 10:07:13 am ---I'd vote for 3>.

--- End quote ---
I`m too.
Morten, where is last version of this patch?
Feneck91, I think, there is not good idea to add it into menu - it must be in Settings->Invironment, where it was before migrating from wxFlatNotebook to wxAuiNotebook.

Feneck91:
I'd vote for 4 !
4> I think like you : let only one menu / shortcut, but add an option to know how to manage tabs :
- Could add into : Setting / Editor... / General Setting .... but where put this option ?
- Could add into : Setting / Environment ... / General Setting .... but where put this option ? After Allow only one running instance or in Notebook appearance.
If you reply, I could make the patch !


I think it is the better solution. question is : where whe should put this option, and how describe it ?

Morten, where is last version of this patch ?

Navigation

[0] Message Index

[#] Next page

[*] Previous page