Developer forums (C::B DEVELOPMENT STRICTLY!) > Development
wxScintilla 2.01
cgarcia109:
I do. That version doesnt include new scintilla notifications nor DinamicLibraryImpl and miss some defines.
It was missing new scintilla files in proyect (selection.cxx|.h lexMarkDown.cxx)
I have changed too
-SCNotification scn = {{0}};
+SCNotification scn; memset((void*)&scn,0,sizeof(scn));
And cleaned some scintilla files of uneeded includes to keep it alligned with scintilla code
ScintillaWX.cxx was missing #include <new> that i think its needed to get exception from bad allocations now that all allocations checks has been removed from scintilla.
[attachment deleted by admin]
cgarcia109:
theres some issue with rectangular selections
when you do a rectangular selection if the last line (the one with the caret that become the mainrange) is empty GetSelectionStart() and GetSelectionEnd() returns the same value. In this case cbEditor::HasSelection() returns false..
In cbEditor::HasSelection()
- return control->GetSelectionStart() != control->GetSelectionEnd();
+ return control->GetSelections()>0;
------------
No, that doesnt do it. GetSelections() always return 1+
MortenMacFly:
--- Quote from: cgarcia109 on September 29, 2009, 01:08:00 pm ---That version doesnt include new scintilla notifications
--- End quote ---
That's not really true... anyways... I synced your code with the one from the branch and there were some mods I will test and probably apply. But most of it was indeed already implemented, just in a different order. It's just that you missed some aspects (so did I ... ;-) so I cannot directly apply it.
--- Quote from: cgarcia109 on September 29, 2009, 01:08:00 pm ----SCNotification scn = {{0}};
+SCNotification scn; memset((void*)&scn,0,sizeof(scn));
--- End quote ---
This doesn't really change anything but it is technically more correct. hence I believe it'll suck some more CPU power, so it needs testing.
MortenMacFly:
--- Quote from: cgarcia109 on September 29, 2009, 07:32:37 pm ---when you do a rectangular selection if the last line (the one with the caret that become the mainrange) is empty
--- End quote ---
I'm afraid I don't understand... If the last line is empty the rectangular is reduced to basically "n lines down and 0 chars left". For me this is an "empty selection"... Could you please post an example when this is not the case? E.g. a code snippet?
Jenna:
Martin:
please don't switch multiple select and additional selection typing on as default.
It should be configurable.
It's an interesting feature, but I don't think it will be used very much and at least additional selection typing (or better typing and deleting at multiple postions at the same time) can be used accidently, especially if a user uses ctrl+left-click for browse-marks and it can be annoying to undo changes you did not want and to click into the editor to have only one caret again.
I think the options can be placed on the Margins and caret pane.
I can do that, if it's okay for you.
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version