Developer forums (C::B DEVELOPMENT STRICTLY!) > Development

wxScintilla 2.01

<< < (4/6) > >>

MortenMacFly:

--- Quote from: MortenMacFly on September 30, 2009, 08:47:17 am ---Just please wait until I commit some pending modifications to the scintilla branch to avoid conflicts.

--- End quote ---
You don't need to wait any longer. ;-) I've added the pending changes into the branch. They work fine here.

cgarcia109:
Hi, just noticed, GetSelectionNStart and GetSelectionNEnd are missing an argument
Changed another 2 lines too

edit:
I see in ScintillaWX::Paste() you added some code at the start of function but without below code the computed firstPosition is not usable


--- Code: ---Index: C:/Projects/scintilla-test-brach/src/sdk/wxscintilla/src/ScintillaWX.cpp
===================================================================
--- C:/Projects/scintilla-test-brach/src/sdk/wxscintilla/src/ScintillaWX.cpp (revision 5834)
+++ C:/Projects/scintilla-test-brach/src/sdk/wxscintilla/src/ScintillaWX.cpp (working copy)
@@ -587,10 +587,9 @@
     int newPos = 0;
     int caretMain = CurrentPosition();
     if (rectangular) {
-        SelectionPosition selStart = sel.Range(sel.Main()).Start();
         int newLine = pdoc->LineFromPosition (caretMain) + wxCountLines (buf, pdoc->eolMode);
         int newCol = pdoc->GetColumn(caretMain);
-        PasteRectangular (selStart, buf, len);
+        PasteRectangular (firstPosition, buf, len);
         newPos = pdoc->FindColumn (newLine, newCol);
     } else {
         pdoc->InsertString (caretMain, buf, len);

--- End code ---
         
About the SCNotification initializations (memset ... ) well it could be just not initialized at all, SCNotification scn; without {0} nor memset(...
All relevant values for an specific notification are set and no other values are used by the notification receiver, it should be asumed for any non relevant values just to be unintialized.

[attachment deleted by admin]

Jenna:

--- Quote from: MortenMacFly on October 01, 2009, 07:53:18 am ---
--- Quote from: MortenMacFly on September 30, 2009, 08:47:17 am ---Just please wait until I commit some pending modifications to the scintilla branch to avoid conflicts.

--- End quote ---
You don't need to wait any longer. ;-) I've added the pending changes into the branch. They work fine here.

--- End quote ---

I will do it later today or the coming weekend.

MortenMacFly:

--- Quote from: jens on October 02, 2009, 07:00:02 am ---I will do it later today or the coming weekend.

--- End quote ---
Don't hurry... I just wanted to mention that the pending modifications are added.

mariocup:
I just compiled scintilla branch and I am getting some strange behaviour (see attachment).

I have the following option enabled (not sure if relevant):
- word wrap
- virtual spaces
- multiple selection

If I select a text in block select mode (end of the line) and press Ctrl+C and then try to insert it, then not the selected text is inserted. Instead some characters of the beginning of the line are inserted.

Is this a bug or any feature that I am not using correctly.

[attachment deleted by admin]

Navigation

[0] Message Index

[#] Next page

[*] Previous page

Go to full version