Developer forums (C::B DEVELOPMENT STRICTLY!) > CodeCompletion redesign
New code completion remarks/issues
ollydbg:
I'm sorry, I find the bug, it's here
line 766-787 of nativeparser.cpp.
--- Code: --- if (!token->m_Args.IsEmpty() && !token->m_Args.Matches(_T("()")))
{
wxString buffer = token->m_Args;
buffer.Remove(0, 1); // remove (
buffer.RemoveLast(); // remove )
buffer.Replace(_T(","), _T(";")); // replace commas with semi-colons
buffer << _T(';'); // aid parser ;)
buffer.Trim();
if (s_DebugSmartSense)
{
#if wxCHECK_VERSION(2, 9, 0)
Manager::Get()->GetLogManager()->DebugLog(F(_T("Parsing arguments: \"%s\""), buffer.wx_str()));
#else
Manager::Get()->GetLogManager()->DebugLog(F(_T("Parsing arguments: \"%s\""), buffer.c_str()));
#endif
if (!buffer.IsEmpty() && !parser->ParseBuffer(buffer, false, false, true))
{
Manager::Get()->GetLogManager()->DebugLog(_T("ERROR parsing arguments"));
}
}
--- End code ---
MortenMacFly:
--- Quote from: ollydbg on October 09, 2009, 08:02:02 am ---I'm sorry, I find the bug, it's here
line 766-787 of nativeparser.cpp.
--- End quote ---
...so?! What exactly is wrong with that portion?
...besides: it works fine here (trunk)...?!
ollydbg:
--- Quote from: MortenMacFly on October 09, 2009, 08:05:53 am ---
--- Quote from: ollydbg on October 09, 2009, 08:02:02 am ---I'm sorry, I find the bug, it's here
line 766-787 of nativeparser.cpp.
--- End quote ---
...so?! What exactly is wrong with that portion?
--- End quote ---
The code is wrapped in the if (s_DebugSmartSense )from rev 5840 to 5845 of the nativeparser.cpp.
MortenMacFly:
--- Quote from: ollydbg on October 09, 2009, 08:09:33 am ---The code is wrapped in the if (s_DebugSmartSense )from rev 5840 to 5845 of the nativeparser.cpp.
--- End quote ---
Argh! Good one. Nevermind... my mistake. :oops: I was always using it *with* DebugSmartSense enabled, so that's why it worked here... Will commit the fix soon...
ollydbg:
--- Quote from: MortenMacFly on October 09, 2009, 08:14:11 am ---
--- Quote from: ollydbg on October 09, 2009, 08:09:33 am ---The code is wrapped in the if (s_DebugSmartSense )from rev 5840 to 5845 of the nativeparser.cpp.
--- End quote ---
Argh! Good one. Nevermind... my mistake. :oops: I was always using it *with* DebugSmartSense enabled, so that's why it worked here... Will commit the fix soon...
--- End quote ---
haha, I think one reason of the mistake: #if wxCHECK_VERSION(2, 9, 0) preprocessor guard is a little annoying. :D
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version