Developer forums (C::B DEVELOPMENT STRICTLY!) > CodeCompletion redesign

Some strange behaviors

<< < (4/4)

blueshake:
for me ,the two patch both work fine.
now , I need to find which one is much better.just need some time.

ollydbg:

--- Code: ---wxString NativeParser::GetCCToken(wxString& line, ParserTokenType& tokenType)
{
    // line contains a string on the following form:
    // "    char* mychar = SomeNamespace::m_SomeVar.SomeMeth"
    // first we locate the first non-space char starting from the *end*:
    //
    // "    char* mychar = SomeNamespace::m_SomeVar.SomeMeth"
    //                     ^
    // then we remove everything before it.
    // after it, what we do here, is (by this example) return "SomeNamespace"
    // *and* modify line to become:
    // m_SomeVar.SomeMeth
    // so that if we 're called again with the (modified) line,
    // we 'll return "m_SomeVar" and modify line (again) to become:
    // SomeMeth
    // and so on and so forth until we return an empty string...
    // NOTE: if we find () args or [] arrays in our way, we skip them (done in GetNextCCToken)...
--- End code ---

The last comment says:　

// NOTE: if we find () args or [] arrays in our way, we skip them (done in GetNextCCToken)...

So, it is better to change the function "GetNextCCToken" I think.

blueshake:
@ollydbg
would you agree to apply the second patch?

ollydbg:

--- Quote from: blueshake on August 27, 2009, 09:57:21 am ---@ollydbg
would you agree to apply the second patch?

--- End quote ---

Yes, I personally prefer the second patch just do the Trim() function.

Navigation

[0] Message Index

[*] Previous page