User forums > Nightly builds

The 27 July 2009 build (5716) is out.

<< < (7/15) > >>

Jenna:

--- Quote from: killerbot on July 30, 2009, 10:05:45 pm ---which is a change to 'compilercommandgenerator.cpp' base upon work of 'Biplab' : "replace macros for compiler options".
Basically 2 lines have been added, doing a macro substitution, could it be it is carried out too early ??

--- End quote ---
It seems so.

In ReplaceMacros, we replace macros and environment-variables.
Our internally used variables have the same format as the unix/linux shell-variables (if used without braces), so they get replaced by the appropriate environment variable, but such a variable does not exist, so we get an empty string instead.

ReplaceMacros should be called after our variables get expanded, not before.

EDIT:

and as I just saw, ReplaceMacros is called at the  end GenerateCommandline, so it I do not think, that there is any cause to call it so early as we do it in the moment (after the changes in commit 5636.
There might be a problem , if a user tries to add C::B variables with a script, but that does not work anyway (unless they are added with two $'s), because the variables get expanded after the scripts.

So my proposal is to revert commit 5636, unless we find a way to protect C::B's internal variables.

MortenMacFly:

--- Quote from: jens on July 30, 2009, 11:30:02 pm ---So my proposal is to revert commit 5636, unless we find a way to protect C::B's internal variables.

--- End quote ---
Agreed. Still: It works for me on Windows even with the patch!!!

EDIT: I've taken the action accordingly.

sbilsing:
The workaround to double the $ works for me, too. :-)
I should have mentioned, that I use the macro in the project's compiler settings, not in the global compiler settings. In the global settings everything seems fine.

MortenMacFly:

--- Quote from: sbilsing on July 31, 2009, 08:34:21 am ---In the global settings everything seems fine.

--- End quote ---
Now THAT clarifies why it seemed to work for me. ;-)

sdfwds4:
brace completion is good, i like it, thank you!

Navigation

[0] Message Index

[#] Next page

[*] Previous page

Go to full version