User forums > Nightly builds
The 27 July 2009 build (5716) is out.
MortenMacFly:
--- Quote from: Loaden on July 28, 2009, 10:32:15 am ---svn build rev 5717 (2009-07-28T07: 15:12.319835 Z) gcc 4.4.1 Windows / unicode
--- End quote ---
That's not wrong, that's exactly how SVN reports the date/time. It's just "a" format. Check any "entries" file in a .svn sub-foldr if you like. It's all the same.
Jenna:
--- Quote from: MortenMacFly on July 28, 2009, 12:53:55 pm ---
--- Quote from: Loaden on July 28, 2009, 10:32:15 am ---svn build rev 5717 (2009-07-28T07: 15:12.319835 Z) gcc 4.4.1 Windows / unicode
--- End quote ---
That's not wrong, that's exactly how SVN reports the date/time. It's just "a" format. Check any "entries" file in a .svn sub-foldr if you like. It's all the same.
--- End quote ---
We parse the date with a regex, if we use automake on linux.
We can do something similar on windows (of course without regexes).
Any objections against this patch:
--- Code: ---Index: autorevision.cpp
===================================================================
--- autorevision.cpp (Revision 5716)
+++ autorevision.cpp (Arbeitskopie)
@@ -122,6 +122,8 @@
if(d && d->GetText())
{
date = d->GetText();
+ date.replace(date.find('T'),1," ");
+ date.resize(date.find('.'));
}
return 1;
}
--- End code ---
MortenMacFly:
--- Quote from: jens on July 28, 2009, 02:09:35 pm ---We parse the date with a regex, if we use automake on linux.
--- End quote ---
Linux I don't know. But he was talking about Windows. However - what's wrong with using the format as it is used in the (any) SVN repository? I mean: We *are* talking about a SVN revision here, right?
Jenna:
--- Quote from: MortenMacFly on July 28, 2009, 03:18:40 pm ---
--- Quote from: jens on July 28, 2009, 02:09:35 pm ---We parse the date with a regex, if we use automake on linux.
--- End quote ---
Linux I don't know. But he was talking about Windows. However - what's wrong with using the format as it is used in the (any) SVN repository? I mean: We *are* talking about a SVN revision here, right?
--- End quote ---
I know that he is talking about windows.
I don't know, why subversion uses this format for date/time of last commit (internally), but are there any objections against using a format, that's (better) human-readable for the date and time ?
The only cause would be, if we have to distinguish between to revision, that came in at the same second, but we also use the revision-number, so I don't see any problem.
And I don't think the patch to autorevision.cpp can break anything, unless the svn date-format changes.
Biplab:
--- Quote from: jens on July 28, 2009, 04:24:26 pm ---
--- Quote from: MortenMacFly on July 28, 2009, 03:18:40 pm ---
--- Quote from: jens on July 28, 2009, 02:09:35 pm ---We parse the date with a regex, if we use automake on linux.
--- End quote ---
Linux I don't know. But he was talking about Windows. However - what's wrong with using the format as it is used in the (any) SVN repository? I mean: We *are* talking about a SVN revision here, right?
--- End quote ---
I know that he is talking about windows.
I don't know, why subversion uses this format for date/time of last commit (internally), but are there any objections against using a format, that's (better) human-readable for the date and time ?
The only cause would be, if we have to distinguish between to revision, that came in at the same second, but we also use the revision-number, so I don't see any problem.
And I don't think the patch to autorevision.cpp can break anything, unless the svn date-format changes.
--- End quote ---
Better consult with Thomas first. Once I wanted to fix this issue. But he didn't want to touch that code. I forgot the exact objection. :)
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version