Developer forums (C::B DEVELOPMENT STRICTLY!) > Development
Splitting debugger in two - specific debugger and common GUI
oBFusCATed:
Morten: About the Chinese chars: If you've tested it and it works, commit at will:) I guess this is related to the additional arguments patch.
Hm, strange. Can you try to debug this, too?
ollydbg: I don't get what is your problem? As far as I know the newly shown windows are not placed by C::B, but by your Explorer.exe.
MortenMacFly:
--- Quote from: oBFusCATed on January 17, 2012, 05:16:56 pm ---If you've tested it and it works, commit at will:) I guess this is related to the additional arguments patch.
--- End quote ---
Nope, its not. I've committed.
oBFusCATed:
Morten:
Can I ask you to stop committing real changes and style changes in a single commit?
I don't know if you have something that automatically fixes the formatting, but it is pretty hard to look at your commits, because mostly they are full of formatting noise.
BTW: you don't follow your style 100%, because you fix code like "if(!test)", to "if (!test)" or "if ( !test )".
At my current company we have the following rule: "you must not change the formatting of code you're not changing"; which is one pretty good rule.
MortenMacFly:
--- Quote from: oBFusCATed on January 17, 2012, 06:25:10 pm ---Can I ask you to stop committing real changes and style changes in a single commit?
--- End quote ---
I think all you need is a good diff tool. The one I use can simply hide "whitespace" changes so you only see what is really changed.
Concerning style: I use an automated astyle run whenever I save a file. My settings are usually consistent and follow the following (in-house company) rules:
1.) After if, for, while follows a space
2.) After the opening and before the closing bracket follows a space only in case a function call is done inside the clause.
I'll try to turn automatic formatting off next time. By default its enabled and I cannot set it "per-project".
BTW: If works even if you use the WEB-SVN:
http://svn.berlios.de/wsvn/codeblocks/branches/wxpropgrid_debugger/src/plugins/debuggergdb/debuggergdb.cpp?op=diff&rev=7703&peg=7703
Only the green and red lines are true changes. You can even enable there to "ignore whitespace changes":
http://svn.berlios.de/wsvn/codeblocks/branches/wxpropgrid_debugger/src/plugins/debuggergdb/debuggergdb.cpp?op=diff&rev=7703&peg=7703&ignorews=1
Easy to catch... ;-)
oBFusCATed:
http://svn.berlios.de/wsvn/codeblocks?op=comp&compare[]=%2Fbranches%2Fwxpropgrid_debugger%2Fsrc%2Fplugins%2Fdebuggergdb%2Fdebuggergdb.cpp@7688&compare[]=%2Fbranches%2Fwxpropgrid_debugger%2Fsrc%2Fplugins%2Fdebuggergdb%2Fdebuggergdb.cpp@7703
I'm looking at this one and it is pretty broken. I use it because it is the easiest to reach.
My diff tool is set up to show any differences, so I don't commit random changes caused by stripping trailing whitespaces, line ending differences and so on.
p.s. we should add per project/workspace style, because the current global style settings are pretty limiting :(
edit:
seems there is an ignore whitespace button there, too :(
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version