Developer forums (C::B DEVELOPMENT STRICTLY!) > Development
Splitting debugger in two - specific debugger and common GUI
oBFusCATed:
Can you state the name of the patches (or direct links to the posts)?
--- Quote from: cbexaminr on May 03, 2011, 04:14:39 am ---3of3)oBFusCATed /Others, the crash possible in Attach to process previously introduced with earlier cdb support related patches does not seem to have been corrected (outside of the not yet accepted/applied patch [with other functionality] I previously submitted.)
--- End quote ---
I've missed this, this could be applied (faster) if you supply a separate patch...(and steps to reproduce the crashes)
BTW Your tooltips patch won't be applied, because it is broken badly on my linux (gentoo + e17). It is pretty complex in its mouse handing/interactions, so it will be hard to maintain.
I've started separate implementation using wxPopupTransientWindow and wxPropertyGrid.
cbexaminr:
--- Quote from: oBFusCATed on May 03, 2011, 08:49:19 am ---Can you state the name of the patches (or direct links to the posts)?
--- End quote ---
dbgextprocess.2b.patch
http://forums.codeblocks.org/index.php/topic,10908.msg95323.html#msg95323
I believe the fix for the issue was merely to make sure m_Target is not NULL before attempting to use to check for ttConsoleOnly.
--- Quote from: oBFusCATed on May 03, 2011, 08:49:19 am ---
--- Quote from: cbexaminr on May 03, 2011, 04:14:39 am ---3of3)oBFusCATed /Others, the crash possible in Attach to process previously introduced with earlier cdb support related patches does not seem to have been corrected (outside of the not yet accepted/applied patch [with other functionality] I previously submitted.)
--- End quote ---
I've missed this, this could be applied (faster) if you supply a separate patch...(and steps to reproduce the crashes)
--- End quote ---
I believe you merely had to start codeblocks without opening a project and then perform an Attach to process.
--- Quote from: oBFusCATed on May 03, 2011, 08:49:19 am ---BTW Your tooltips patch won't be applied, because it is broken badly on my linux (gentoo + e17). It is pretty complex in its mouse handing/interactions, so it will be hard to maintain.
--- End quote ---
OK.
("broken" I accept as reason not to aply.
Complex to maintain I don't accept, unless a)it can be reasonably speculated that some desired functionality will likely have to be added, or, b)that the functiionality it provides is not useful and desireable, or c)that there is a simpler way to accomplish the same functionality without the complexity, or d)it makes use of wxwidgets features that are known to be platform inconsistent, or unstable or likely to change [possibly the situation if it is "broken" on linux].
Further, it was merely intended as a prototype, not necessarily to be applied in its current state - all of that code was exploratory, with regard to the windows without borders on both Windows and Linux and possibly other issues I don't recall at this point)
--- Quote from: oBFusCATed on May 03, 2011, 08:49:19 am ---I've started separate implementation using wxPopupTransientWindow and wxPropertyGrid.
--- End quote ---
OK.
oBFusCATed:
--- Quote from: cbexaminr on May 03, 2011, 12:28:59 pm ---I believe the fix for the issue was merely to make sure m_Target is not NULL before attempting to use to check for ttConsoleOnly.
--- End quote ---
Can you check it, again?
--- Quote from: cbexaminr on May 03, 2011, 12:28:59 pm ---dbgextprocess.2b.patch
--- End quote ---
I can't give you a time frame for the refactoring. At the moment I'm working on tooltips, as they have more impact on users and plugin writers.
--- Quote from: cbexaminr on May 03, 2011, 12:28:59 pm ---OK.
("broken" I accept as reason not to aply.
Complex to maintain I don't accept, unless a)it can be reasonably speculated that some desired functionality will likely have to be added, or, b)that the functiionality it provides is not useful and desireable, or c)that there is a simpler way to accomplish the same functionality without the complexity, or d)it makes use of wxwidgets features that are known to be platform inconsistent, or unstable or likely to change [possibly the situation if it is "broken" on linux].
Further, it was merely intended as a prototype, not necessarily to be applied in its current state - all of that code was exploratory, with regard to the windows without borders on both Windows and Linux and possibly other issues I don't recall at this point)
--- End quote ---
The thing is that it does many complex things with windows. It needs borderless windows, it needs correctly working hovering.
And implementing this on all platforms will be hard and will increase the maintenance cost.
I'll see if my approach will be simpler. It will be something like this: http://monodevelop.com/@api/deki/files/286/=md24-PinnedDebugValues.png
oBFusCATed:
OK, I've done some work on the tooltips and there are some problems :(
The main problem is that the keyboard input inside wxPopupWindow is very buggy or it even doesn't work (on wxMSW). :evil: :twisted: :cry: :?: :| :x :shock: :?
The simplest solution is to surrender and make the tooltips read-only. Not a good solution from the usability point of view.
Has anyone done any complex tooltips using wxWidgets?
I'll post a patch with read-only tooltips later today...
oBFusCATed:
Ok, I have the patch for the tooltips almost ready: http://smrt.is-a-geek.org/codeblocks/patches/dbg/dbg_refactor0022.3.patch
Please test it. I'm using it every day on my linux, but have done very little testing on windows, so feedback is welcome.
Changes:
- Added API for showing value tooltips from debugger plugins
- Added implementation of the tooltip using wxPropertyGrid
- Imported std::tr1::shared_ptr in namespace cb, replaced all usages of std::tr1::shared_ptr with cb::shared_ptr (this should make it very easy to change the shader_ptr implementation)
- Some of the functions have been changed to return or take cbWatch::Pointer instead of raw pointers (all should be changed, but this will be done later)
- Added 'Require Ctrl key to be pressed to show the Value tooltip'
- Changed wxPropertyGrid to support the autosizing (logged issue request upstream)
- Added code to correctly hide the CC tooltips
- Some refactoring here and there.
Feedback please...
If there are no reports for problems, I'll commit in the next couple of weeks...
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version