Developer forums (C::B DEVELOPMENT STRICTLY!) > Development
Splitting debugger in two - specific debugger and common GUI
dmoore:
--- Quote from: oBFusCATed on February 28, 2011, 08:56:31 am ---Next patch (it doesn't apply for me, but should show you what should be done): http://smrt.is-a-geek.org/codeblocks/patches/dbg/dbg_refactor0019.4.patch
...
Next patch (main patch for the post): http://smrt.is-a-geek.org/codeblocks/patches/dbg/dbg_refactor0020.0.patch
...
--- End quote ---
I applied both patches, which applied with some weirdness (some of this stuff has been applied previously?). C::B builds fine and I can see the new dialog. Looks good, but I haven't spent much time testing the functionality. So what is the major breakage here? :)
oBFusCATed:
0019.4 seems applied by Morten.
The main breakage will probably be related to the new "Debug -> Active debuggers -> Target's default" feature.
Also most of the exotic embedded targets won't have correct default settings for the debugger...
oBFusCATed:
Two new patches:
1. http://smrt.is-a-geek.org/codeblocks/patches/dbg/dbg_refactor0019.5.patch
Fixes:
* Step into was not working on windows (the code was different on windows/mac and linux, not it is the same on all platforms)
* Marked on of the reg expressions to use the wxRE_ADVANCED
2. http://smrt.is-a-geek.org/codeblocks/patches/dbg/dbg_refactor0019.6.patch
Fixes:
* Refactored a bit the stack frame parsing code (extracted it in a function)
* Added tests for stack frame parsing
* Another case of stack frame output is parsed correctly ("#11 0x00406810 in main ()")
* Refactored a bit the debuggergdb test project
All development and testing is done on windows, I'll test it on linux later today. Probably patch 20.0 won't apply anymore, I'll fix that, too.
Morten, can I ask you to reject any patches (even made by me), which change a regexp and don't provide a test for it?
MortenMacFly:
--- Quote from: oBFusCATed on March 03, 2011, 02:32:58 pm ---1. http://smrt.is-a-geek.org/codeblocks/patches/dbg/dbg_refactor0019.5.patch
--- End quote ---
Concerning this one: Hopefully you noticed that you've removed a work-around for windows, namely stated in this comment:
--- Code: --- // under windows, 'start' segfaults with wx projects...
--- End code ---
So either this is fixed in recent GDB's (did you try that functionality on all platforms?), or you might have overseen. Any comment on that?
dmoore:
--- Quote from: oBFusCATed on March 02, 2011, 12:11:50 am ---0019.4 seems applied by Morten.
The main breakage will probably be related to the new "Debug -> Active debuggers -> Target's default" feature.
Also most of the exotic embedded targets won't have correct default settings for the debugger...
--- End quote ---
Is that because of the various instances of this:
--- Code: ---- m_Programs.DBG = _T("ppc-insight.exe");
+ m_Programs.DBGconfig = wxEmptyString; // _T("ppc-insight.exe");
--- End code ---
not sure why you are setting them to empty strings...
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version