Developer forums (C::B DEVELOPMENT STRICTLY!) > Development

Splitting debugger in two - specific debugger and common GUI

<< < (78/136) > >>

oBFusCATed:
1. Yes, this is it
2. They share the UI and there is Manager::Get()->GetDebuggerManager()->GetActiveDebugger(). You can change the active debugger with Debug->Active debugger. I think the active debugger can't be changed during the debug session. This should change in the future, but I've not thought about it, much. Probably it should be possible to debug with a combination of plugins  -> 'C++ + python' or 'c++ + lua' (I use this combination, but no lua debugger at the moment :( )
3. No problem, there is a Start method or something like that. There you can do whatever you like or is appropriate.
4. There is some common setup happening in OnAttach/OnRelease, then they call OnAttachReal/OnReleaseReal. If you can think of better names I can change them no problem.
    And I hope we won't add any more methods with Reals at the end :)

MortenMacFly:

--- Quote from: oBFusCATed on February 05, 2011, 07:55:46 am ---4. There is some common setup happening in OnAttach/OnRelease, then they call OnAttachReal/OnReleaseReal. If you can think of better names I can change them no problem.
    And I hope we won't add any more methods with Reals at the end :)

--- End quote ---
How about renaming the first to "OnAttachBase" and the speci alised methods to "OnAttach"?!

Jenna:

--- Quote from: MortenMacFly on February 05, 2011, 10:54:37 am ---
--- Quote from: oBFusCATed on February 05, 2011, 07:55:46 am ---4. There is some common setup happening in OnAttach/OnRelease, then they call OnAttachReal/OnReleaseReal. If you can think of better names I can change them no problem.
    And I hope we won't add any more methods with Reals at the end :)

--- End quote ---
How about renaming the first to "OnAttachBase" and the speci alised methods to "OnAttach"?!

--- End quote ---
Or OnAttach and DoAttach, as we do it on other places.

oBFusCATed:
+1 for Jens' suggestion
-1 to Morten's, because OnAttach is declared in cbPlugin, so I can't change its name.

Another options is

--- Code: ---MyPlugins::OnAttach(...)
{
    cbDebugger::OnAttach(...);
    ....
}

--- End code ---

But I don't like it too much.

dmoore:

--- Quote from: oBFusCATed on February 05, 2011, 07:55:46 am ---1. Yes, this is it
2. They share the UI and there is Manager::Get()->GetDebuggerManager()->GetActiveDebugger(). You can change the active debugger with Debug->Active debugger. I think the active debugger can't be changed during the debug session. This should change in the future, but I've not thought about it, much. Probably it should be possible to debug with a combination of plugins  -> 'C++ + python' or 'c++ + lua' (I use this combination, but no lua debugger at the moment :( )
3. No problem, there is a Start method or something like that. There you can do whatever you like or is appropriate.
4. There is some common setup happening in OnAttach/OnRelease, then they call OnAttachReal/OnReleaseReal. If you can think of better names I can change them no problem.
    And I hope we won't add any more methods with Reals at the end :)

--- End quote ---

Based on this, I should be able to simply reuse large chunks of my old Python Debugger Plugin then gradually refactor it. I'll hopefully report back next week...

Navigation

[0] Message Index

[#] Next page

[*] Previous page

Go to full version