Developer forums (C::B DEVELOPMENT STRICTLY!) > Development

Trunk broken somewhen since r5680

<< < (2/2)

Jenna:

--- Quote from: Mephistopheles on July 20, 2009, 04:29:34 am ---Regarding the general stuff I probably was too optimistic cause builds for Mandriva 2008, 2009 and openSUSE 10.3 are still failing with stuff like


--- Code: --- i586-mandriva-linux-gnu-g++ -DHAVE_CONFIG_H -I. -I../../src/include -I/usr/lib/wx/include/ -I/usr/lib/wx/include/gtk2-unicode-release-2.8 -I/usr/include/wx-2.8 -D_FILE_OFFSET_BITS=64 -D_LARGE_FILES -D__WXGTK__ -pthread -I../../src/include -I../../src/include/wxscintilla/include -I../../src/include/tinyxml -I../../src/include/scripting/include -I../../src/include/scripting/sqplus -I../../src/include/mozilla_chardet -Ulinux -Uunix -O2 -ffast-math -DCB_AUTOCONF -O2 -pipe -Wp,-D_FORTIFY_SOURCE=2 -fstack-protector --param=ssp-buffer-size=4 -fexceptions -fomit-frame-pointer -march=i586 -mtune=generic -fasynchronous-unwind-tables -DCB_PRECOMP -Winvalid-pch -fPIC -DPIC -fexceptions -MT editormanager.lo -MD -MP -MF .deps/editormanager.Tpo -c editormanager.cpp -fPIC -DPIC -o .libs/editormanager.o
editormanager.cpp:137: error: 'EVT_AUINOTEBOOK_TAB_RIGHT_UP' was not declared in this scope
editormanager.cpp:138: error: expected `}' before 'wxEventTableEntry'
editormanager.cpp:138: error: expected ',' or ';' before 'wxEventTableEntry'
editormanager.cpp:151: error: expected declaration before '}' token
make[3]: *** [editormanager.lo] Error 1
--- End code ---

--- End quote ---

This might be because of many changes/improvements to wxAuiNotebook in wx2.8.5. As you wrote openSUSE 10.3 and Mandriva 2008 use 2.8.4 .
The problem is, that C::B uses wxAuiNotebook instead of wxFlatNotebook for almost all notebooks now (except from notebooks in config-dialogs).
I think a backport is not possible with a reasonable amount of work:

--- Quote from: wxWidgets-changes for 2.8.5 ---- Added tab mouse click events to wxAuiNotebook (Ben Williams).
- Option for middle-click tab close in wxAuiNotebook (Ben Williams).
- Added wxAuiNotebook::SetFont, GetTabCtrlHeight, GetHeightForPageHeight.
[...]
- Added AdvanceSelection, ShowWindowMenu functions and keyboard handling to
  wxAuiNotebook.
- Added wxAUI_NB_SUPPORT for standard wxAuiNotebook art (Langhammer).
- Added event for double clicks on wxAuiNotebook tab background.
- Added events for wxAuiNotebook tab dragging and closing notification.
[...]
- Fixed a wxTabFrame leak by deleting all wxAuiNotebook pages in the destructor.

--- End quote ---

If I find a solution for the other issues I will post them here.

Jenna:
Hi,

It would be nice, if you can test the attached patch.

It should fix the undefined references in wxSmithContribItems and the wxAuiToolbar problem.

If it works, I will commit it.

As I wrote before, there's no fix for OS10.3 and Mandriva 2008, because reverting to wxFlatNotebook is not an option.
For these two, the last revision that should work is svn r5681.

[attachment deleted by admin]

Mephistopheles:

--- Quote from: jens on July 21, 2009, 08:16:03 pm ---It would be nice, if you can test the attached patch.

It should fix the undefined references in wxSmithContribItems and the wxAuiToolbar problem.

If it works, I will commit it.
--- End quote ---

Sorry, I'm not sure if I got you right. As far as I understood you that patch is supposed to solve the issue from the very first post so I don't need some if else stuff in my .spec to compile some versions with "--with-contrib-plugins=all,-wxsmithaui", right?

If so it sadly doesn't work. The error still is the exact same and the full build log for openSUSE 11.1 can be seen here (applied cleanly against r5695).


--- Quote from: jens on July 21, 2009, 08:16:03 pm ---As I wrote before, there's no fix for OS10.3 and Mandriva 2008, because reverting to wxFlatNotebook is not an option.
For these two, the last revision that should work is svn r5681.
--- End quote ---

That's fine, I just wanted to ensure that it isn't me who's screwing it up.

If you find the time to come up with another patch I'll happily play the guinea pig but, as you saw, it can take a few days due to a lack of time atm.

Jenna:

--- Quote from: Mephistopheles on July 23, 2009, 05:23:04 pm ---Sorry, I'm not sure if I got you right. As far as I understood you that patch is supposed to solve the issue from the very first post so I don't need some if else stuff in my .spec to compile some versions with "--with-contrib-plugins=all,-wxsmithaui", right?

--- End quote ---

Yes.

Here comes another patch.

[attachment deleted by admin]

Mephistopheles:
Great one! That patch fixed all builds except Mandriva 2008 & openSUSE 10.3 which wont work anyways as stated. Thanks for that :)

Now we are down to the strict-aliasing warnings:

--- Code: ---I: Program is likely to break with new gcc. Try -fno-strict-aliasing.
W: codeblocks strict-aliasing-punning ../../../../src/include/scripting/sqplus/sqplus.h:420, 1801
W: codeblocks strict-aliasing-punning sqcompiler.cpp:652
W: codeblocks strict-aliasing-punning sqstdblob.cpp:160, 168
W: codeblocks strict-aliasing-punning sqstdsystem.cpp:55
W: codeblocks strict-aliasing-punning sqvm.cpp:712
--- End code ---

and openSUSE Factory / 11.2 failing with http://pastebin.be/19858

Navigation

[0] Message Index

[*] Previous page