Developer forums (C::B DEVELOPMENT STRICTLY!) > CodeCompletion redesign

new CC branch built failed

<< < (2/5) > >>

MortenMacFly:

--- Quote from: ollydbg on July 09, 2009, 08:35:38 am ---If a file is opened by context menu-> open #include file "XXXX.h", then the CodeBrowser tree of "XXXX.h" will not be updated.

--- End quote ---
How was that in previous version(s)? Is that really in the new CC branch only?
BTW: There are some more (minor) glitches I found. I'll post them when I'm back from holiday... probably you've found yourself by then already... ;-)

ollydbg:

--- Quote from: MortenMacFly on July 09, 2009, 11:47:53 am ---How was that in previous version(s)? Is that really in the new CC branch only?

--- End quote ---
Yes, at least this bug is not in official nightly build version. :D

BTW, Have a nice holiday!!!

ollydbg:
The bug seems located in these code, I have debug CB in CB :D:


--- Code: ---void NativeParser::OnEditorActivated(EditorBase* editor)
{
    if (!m_pClassBrowser)
        return;
    cbEditor* ed = editor && editor->IsBuiltinEditor() ? static_cast<cbEditor*>(editor) : 0;
    if (ed)
    {
        Parser* parser = FindParserFromEditor(ed);
        if (parser && parser->ClassBrowserOptions().displayFilter == bdfFile)
        {
            m_pClassBrowser->UpdateView();
        }
    }
}

--- End code ---

When I right click to open a  "#include XXXX.h" file, then CC will receive  an editor active command, then the code above will be called.

But I'm sure the ed == NULL. :D

So, that's the reason why m_pClassBrowser not updated.

Jenna:

--- Quote from: ollydbg on July 10, 2009, 08:42:54 am ---But I'm sure the ed == NULL. :D

So, that's the reason why m_pClassBrowser not updated.

--- End quote ---

Good catch, but this bug is a bug that slipped in with the use of wxAuiNotebook and not new CC.

It seems the editormanager gets the PageChanged event, before the editor is initialized.
In it's PageChanged event-handler it sends the cbEVT_EDITOR_ACTIVATED-event and therefore IsBuiltinEditor() returns false in this case.

I will look into it.

ollydbg:

--- Quote from: jens on July 10, 2009, 10:14:15 am ---
--- Quote from: ollydbg on July 10, 2009, 08:42:54 am ---But I'm sure the ed == NULL. :D

So, that's the reason why m_pClassBrowser not updated.

--- End quote ---

Good catch, but this bug is a bug that slipped in with the use of wxAuiNotebook and not new CC.

It seems the editormanager gets the PageChanged event, before the editor is initialized.
In it's PageChanged event-handler it sends the cbEVT_EDITOR_ACTIVATED-event and therefore IsBuiltinEditor() returns false in this case.

I will look into it.


--- End quote ---

Just a remainder, this bug seems still exist by now. :D

Navigation

[0] Message Index

[#] Next page

[*] Previous page