Developer forums (C::B DEVELOPMENT STRICTLY!) > Development

Command entry in the debug log patch

(1/5) > >>

oBFusCATed:
Hello,
Here is a patch that adds an entry control in the debug log.
With this entry the user can send commands to the debugger easily.

This patch implements the basic functionality.
If the C::B devs think that the code is good and that is the proper way to add the entry,
further work can(will) be done (making it look like the script console).

Best regards

p.s. the patch is attached

ollydbg:
You are so smart and this plugin works perfectly. :D
Thank you very much!

By the way: should be added to trunk. :shock:

killerbot:
little suggestion :

wxString cmd = m_pLog->GetCommandEntry().GetValue()


Would it not be better to hide the fact there's a wxTextCtrl, and something like :
m_pLog->GetCommand(),

That way we can always change the implementation of the DebugTextCtrlLogger, and there's one user less to worry about.

oBFusCATed:
It could be done, but ClearCommandEntry() should also be added, because I clear the entry field on a command.

But do you think that the way/direction is right?

Edit:

Here is the patch modified to met the killerbot suggestion

mariocup:
Hi oBFusCATed,

I tested your modification and it has been really missing in CB for embedded development. The entry field is quite decent, so it is not so obvious for users. I would prefer:
1. A background color to distinguish the entry field from the rest of Debugger console or
2. Add a small Text like: Debugger Console Input:

I hope that your patch will be integrated soon in the trunk :-).

Navigation

[0] Message Index

[#] Next page