User forums > Help
workspace file changes and source control
MortenMacFly:
--- Quote from: raybert on April 13, 2009, 09:52:18 pm ---- Any such tools already have to deal with both slashes (because they already differ depending on which OS you saved the workspace under).
--- End quote ---
Exactly not. That's my point: The tools just "copy" the content as a file string. This then is used to open the file pointer using (probably) OS calls. So if we change the path forward slashes on Windows such functionality won't work anymore.
Anyways - I think the topic has been discussed enough. Time to get hands on and provide patches...
raybert:
hmm... so, if I save a workspace on Linux, commit it to source control, refresh my Windows work area, and then try to convert it using one of these tools, it will fail because the tool doesn't bother to check the slashes?
If that's the case then I would argue that the tool in question has a bug.
As for patches, I was thinking last night that if I patch CB and make my team use the patched version then that's one way forward for me (and it's cleaner than using VCS hooks). I imagine that these patches wouldn't be very difficult. So I will likely try to find some time to work on this and I'll submit my patches (even if the devs ultimately decide not to commit them).
~ray
MortenMacFly:
--- Quote from: raybert on April 14, 2009, 06:20:55 pm ---So I will likely try to find some time to work on this and I'll submit my patches (even if the devs ultimately decide not to commit them).
--- End quote ---
Sounds good to me. Notice that we do discuss patches internally. So it *is* likely it will be applied as at least one other dev pro's the modification... ;-) That I don't like it doesn't necessarily mean a show-stopper.
raybert:
I finally got around to working on a patch to address these issues.
The attached patch (against svn 5456) causes filenames in workspaces to be always written with forward slashes. It also disables saving the active project. Additionally, it prevents the workspace from being marked dirty when the active project is changed (doesn't make much sense to do that if it's not being saved anyway).
One thing it doesn't do is to save the active project in a different file as I suggested earlier. I don't need that for my own use but, if it's desired, it shouldn't be hard to do (and I'll try to find time to do it).
This is my first patch and I'm not sure of the protocol here. Should I post this to the tracker as well? I have a few more itches to scratch so this probably won't be my last. ;)
~ray
[attachment deleted by admin]
killerbot:
yes, please add if through the tracker on our berlios page, so it won't get lost ;-)
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version