Author Topic: some little modifs  (Read 2889 times)

Leroy

  • Guest
some little modifs
« on: April 07, 2009, 08:24:52 pm »

   Hi !

      I am new to C::B
   Using Windows VisualStudio for many years (from VC6 to VC2008) I found that C::B is quite a good job

   Looking at the code, I found some little bug/modifs that I submit.
   I join a patch file according to the list below.

   More modifs or suggestions will follows.

Code


Note: Some diffs are only trailing spaces

- In EnvironmentSettingsDlg::EnvironmentSettingsDlg()
if (info);
XRCCTRL(*this, "cbxLanguage", wxComboBox)->SetStringSelection(info->Description);
No ';' after info
- In MainFrame::OnEditBoxCommentSelected()
missing breaks in switch (stc->GetEOLMode())
- In FileFilters::GetFilterIndexFromName()
add break after found = true
- const for FilesGroupsAndMasks
- In class EncodingDetector
IsUTF8Tail() should be static
methods following IsUTF8Tail() with const wxByte *
- In class InfoPane
Hide() has no implem. -> remove
- In wxsFontData::BuildFont() wxsfontproperty.cpp
add else(s) in if (SysFont ==
- In class wxsFontEditorDlg
Data is member AND param in ReadData(), StoreData() (seems param precedence)

- In CompilerGCC::Dispatcher()
else if(s) instead of if(s)
- In CompilerGCC::BuildModuleMenu()
remove accels from menuitem name cause keybinder

- In DebuggerGDB::RunCommand()
missing breaks for CMD_MEMORYDUMP and CMD_RUNNINGTHREADS
- In GDB_driver::RunningThreads()
add check: m_pThreads before

- In wxKeyBinder::operator==(const wxKeyBinder& tocomp)
should return true at end (but ok anyway cause not used)

- In various places dialogs are newed and Destroy(): -> better local var
CompilerOptionsDlg::OnSelectProgramClick()
DefaultMimeHandler::ChooseExternalProgram()
EditMimeTypesDlg::OnBrowseProgram()
FilePathPanel::OnbtnBrowseClick()
cbEditor::SaveAs()
cbWorkspace::SaveAs()
SelectTargetDlg::OnHostApplicationButtonClick()
wxPageContainer::OnShowCustomizeDialog()
MainFrame::ShowOpenFileDialog()
MainFrame::DoOnFileOpen()
MainFrame::OnHelpAbout()
ScriptConsole::OnbtnLoadClick()
ScriptingSettingsDlg::OnBrowse()

- add ask_assocs.xrc to project

- Code Completion
no mask for namespace.png
brighter front color (green #) for preproc.png preproc_folder.png (useful for dark background)


[attachment deleted by admin]

Offline ollydbg

  • Developer
  • Lives here!
  • *****
  • Posts: 5736
  • OpenCV and Robotics
    • Chinese OpenCV forum moderator
Re: some little modifs
« Reply #1 on: April 08, 2009, 03:06:33 am »
 :shock:,a lot of improvement!
I have applied in my local copy and build successfully.
Thanks.
If some piece of memory should be reused, turn them to variables (or const variables).
If some piece of operations should be reused, turn them to functions.
If they happened together, then turn them to classes.