Developer forums (C::B DEVELOPMENT STRICTLY!) > Development

Minor bugs-fixed.

(1/2) > >>

mmkider:
I found some bugs for index-error in the codeblocks.
they are very minor bugs.
see that


--- Code: ---Index: debuggeroptionsprjdlg.cpp
===================================================================
--- debuggeroptionsprjdlg.cpp (revision 5492)
+++ debuggeroptionsprjdlg.cpp (working copy)
@@ -91,7 +91,7 @@
     {
         lstBox->Delete(idx);
     }
-    if((size_t)idx > lstBox->GetCount())
+    if((size_t)idx >= lstBox->GetCount())
     {
         idx--;
     }
@@ -150,7 +150,7 @@
         // if we renamed it, just break, there can only be one map per target
         break;
     }

--- End code ---



--- Code: ---Index: cbproject.cpp
===================================================================
--- cbproject.cpp (revision 5492)
+++ cbproject.cpp (working copy)
@@ -1972,7 +1972,7 @@
             if (vt.Index(nameOrder[i]) != wxNOT_FOUND)
             {
                 vt.Remove(nameOrder[i]);
-                vt.Insert(nameOrder[i], i);
+         vt.Insert(nameOrder[i],vt.Count()<=i? vt.Count()-1:i);
             }
         }
     }

--- End code ---

[attachment deleted by admin]

mmkider:
In rev 5497 of codeblocks.


--- Quote ---618F1513  D:\WIDE_ARM\Development\WindowsPlatform\Src\ExeProject\CodeBlocks_debug\src\devel\codeblocks.dll:618F1513  ProjectOptionsDlg::OnUpdateUI(wxUpdateUIEvent&)  D:/WIDE_ARM/Development/WindowsPlatform/Src/ExeProject/CodeBlocks_debug/src/sdk/projectoptionsdlg.cpp:1031

--- End quote ---


--- Code: ---    XRCCTRL(*this, "btnExecutionDir", wxTextCtrl)->Enable(customMake);

--- End code ---
need change code to

--- Code: ---    XRCCTRL(*this, "btnExecutionDir", wxButton)->Enable(customMake);

--- End code ---

Jenna:

--- Quote from: mmkider on April 03, 2009, 04:48:26 am ---In rev 5497 of codeblocks.


--- Quote ---618F1513  D:\WIDE_ARM\Development\WindowsPlatform\Src\ExeProject\CodeBlocks_debug\src\devel\codeblocks.dll:618F1513  ProjectOptionsDlg::OnUpdateUI(wxUpdateUIEvent&)  D:/WIDE_ARM/Development/WindowsPlatform/Src/ExeProject/CodeBlocks_debug/src/sdk/projectoptionsdlg.cpp:1031

--- End quote ---


--- Code: ---    XRCCTRL(*this, "btnExecutionDir", wxTextCtrl)->Enable(customMake);

--- End code ---
need change code to

--- Code: ---    XRCCTRL(*this, "btnExecutionDir", wxButton)->Enable(customMake);

--- End code ---

--- End quote ---

fixed in svn r5498

Thank you !

mmkider:
Fixed：
       1.  Path of generated files always keep $file_dir  in the   generated files (to be further compiled) windows.
       2. Insert index need be checked.


--- Code: ---Index: cbproject.cpp
===================================================================
--- cbproject.cpp (revision 5611)
+++ cbproject.cpp (working copy)
@@ -749,7 +749,7 @@
             for (size_t i = 0; i < tool->generatedFiles.GetCount(); ++i)
             {
                 tmp.SetFullName(tool->generatedFiles[i]);
-                wxString tmps = tmp.GetFullPath();
+                wxString tmps = tmp.GetFullName();
                 // any macro replacements here, should also be done in
                 // CompilerCommandGenerator::GenerateCommandLine !!!
                 tmps.Replace(_T("$file_basename"), f->file.GetName()); // old way - remove later
@@ -2008,7 +2008,7 @@
             if (vt.Index(nameOrder[i]) != wxNOT_FOUND)
             {
                 vt.Remove(nameOrder[i]);
-                vt.Insert(nameOrder[i], i);
+         vt.Insert(nameOrder[i],vt.Count()<=i? vt.Count()-1:i);
             }
         }
     }

--- End code ---

[attachment deleted by admin]

MortenMacFly:

--- Quote from: mmkider on May 27, 2009, 03:14:50 am ---       1.  Path of generated files always keep $file_dir  in the   generated files (to be further compiled) windows.

--- End quote ---
I would love to apply that one (the other one I have already applied in my local copy), but I don't understand. Can you try to explain differently / in other words / with an example, please?!

Navigation

[0] Message Index

[#] Next page