Developer forums (C::B DEVELOPMENT STRICTLY!) > CodeCompletion redesign

Suggest on changing the Variables name in Tokenizer

(1/2) > >>

ollydbg:
In the Tokenizer class include Tokenizer.cpp and Tokenizer.h.

I think these member names should be changed to confirm the coding style.


--- Code: ---   
m_peek             ->  m_PeekToken
m_curtoken        -> m_CurToken
m_peekavailable  -> m_PeekAvailable

--- End code ---

I do think it is necessary, really? :D

MortenMacFly:

--- Quote from: ollydbg on March 11, 2009, 02:40:11 am ---
--- Code: ---   
m_peek             ->  m_PeekToken
m_curtoken        -> m_CurToken
m_peekavailable  -> m_PeekAvailable

--- End code ---

--- End quote ---
No objections. Could you provide a patch?

ollydbg:
Ok.
I have created a patch. See the attachment file. (I have successfully built them in my windows svn 5482)
I change the m_curtoken   -> m_Token
So that there are three groups members. Also, I change the Tokenizer.cpp's encoding to UTF8 without BOM.

Current:
m_Token XXX 
......
Undo:
m_UndoTokenXXX
......
Peek:
m_PeekTokenXXX
......

Also, I change the sequence of initial member list in the constructor to avoid compiling warnings.

[attachment deleted by admin]

MortenMacFly:

--- Quote from: ollydbg on March 11, 2009, 12:12:38 pm ---I have created a patch.

--- End quote ---
Thanks. Give me some days to test it...


BTW, this:

--- Quote from: ollydbg on March 11, 2009, 12:12:38 pm ---Also, I change the Tokenizer.cpp's encoding to UTF8 without BOM.

--- End quote ---
...caused a comment to be not readable anymore. So I am not going to apply the UTF8 change. Be careful with such. ;-)

ollydbg:
OK
The reason I change it's encoding is that by default, the "search thread" can't do search on this file( a messagebox will jump to say "can't open this file  :(), but after changing to UTF8 with out BOM( I converted it by NotePad++), then it can be searched correctly. :D

Navigation

[0] Message Index

[#] Next page