Developer forums (C::B DEVELOPMENT STRICTLY!) > Development

wxComboBox @ wxWidgets 2.6.2

(1/3) > >>

Ceniza:
I started working with the newest wxWidgets release (2.6.2) a few days ago and compiled the latest Code::Blocks CVS with it. I noticed the Build target ComboBox in the toolbar wasn't working as it should and trying to find the reason for it I found in the changes file this little thingy:


--- Quote from: config file for wxWidgets 2.6.2 ---- wxChoice and wxComboBox::GetSelection() now returns completed selection, added a new GetCurrentSelection() function having the old behaviour.
--- End quote ---

Searching for version macros I found wxCHECK_VERSION and I'm proposing to use it:


--- Code: ---#if wxCHECK_VERSION(2, 6, 2)
  m_TargetIndex = m_ToolTarget->GetCurrentSelection() - (m_HasTargetAll ? 1 : 0);
#else
  m_TargetIndex = m_ToolTarget->GetSelection() - (m_HasTargetAll ? 1 : 0);
#endif
--- End code ---

That's from plugins/compilergcc/compilergcc.cpp line 1821 if you wonder.

It might be added somewhere else too... you're the ones who know the whole source.

David Perfors:
Strange, this isn't documented in the manuals.... :?

Ceniza:

--- Quote from: mispunt ---Strange, this isn't documented in the manuals.... :?
--- End quote ---

I just checked the help file and it'sn't commented in wxComboBox, but it's in wxChoice. Anyway, the list of changes is here

David Perfors:
I looked to it, and it seems that there are very much places where it has to be added. Just search for GetSelection and you will find a lot of places where it is found :?
I will work on this tommorow evening.

Ceniza:
Yep, there's a lot, but it seems like just a few need to be replaced (only those called for wxComboBox and wxChoice).

Anyway, nice to know you'll work on it.

Navigation

[0] Message Index

[#] Next page