Author Topic: The 25 August 2007 build will NOT be out.  (Read 5483 times)

Offline killerbot

  • Administrator
  • Lives here!
  • *****
  • Posts: 5193
The 25 August 2007 build will NOT be out.
« on: August 25, 2007, 11:00:38 pm »

Offline thomas

  • Administrator
  • Lives here!
  • *****
  • Posts: 3979
Re: The 25 August 2007 build will NOT be out.
« Reply #1 on: August 26, 2007, 12:18:04 am »
Martin reverted it though? So... nothing to solve?
"We should forget about small efficiencies, say about 97% of the time: Premature quotation is the root of public humiliation."

Offline stahta01

  • Lives here!
  • ****
  • Posts: 6672
    • My Best Post
Re: The 25 August 2007 build will NOT be out.
« Reply #2 on: August 26, 2007, 05:12:14 am »
SVN 4410 crashes on my WinXP SP2, wxWidgets 2.8 Branch

Tim S

PS: Trying backgroundthread.h SVN 4181 now to see if it works OK. It seemed to fix the Crash on startup issue. Note, I only changed the one file from SVN 4410.

The patch to revert backgroundthread.h to SVN 4181 is below.
Code: [Select]
Index: src/include/backgroundthread.h
===================================================================
--- src/include/backgroundthread.h (revision 4410)
+++ src/include/backgroundthread.h (working copy)
@@ -27,18 +27,13 @@
 * BackgroundThreadPool is a low overhead thread pool implementation around BackgroundThread.
 */
 
+
 class AbstractJob
 {
-    friend class BackgroundThread;
-
-    bool deleted;
-    bool done;
-
 public:
-    AbstractJob() : deleted(false), done(false) {};
+    AbstractJob(){};
     virtual ~AbstractJob(){};
     virtual void operator()() = 0;
-    void Delete() { deleted = true; if(done) delete this;};
 };
 
 
@@ -155,20 +150,10 @@
                 break;
 
             job = queue->Pop();
-
-            if(job->deleted)
-            {
-                delete job;
-                continue;
-            }
-
             (*job)();
-            job->done = true;
 
-            if(job->deleted || ownsJobs)
-            {
+            if(ownsJobs)
                 delete job;
-            }
         }
         return 0;
     };
« Last Edit: August 26, 2007, 05:47:03 am by stahta01 »
C Programmer working to learn more about C++ and Git.
On Windows 7 64 bit and Windows 10 32 bit.
On Debian Stretch, compiling CB Trunk against wxWidgets 3.0.
--
When in doubt, read the CB WiKi FAQ. http://wiki.codeblocks.org

Offline killerbot

  • Administrator
  • Lives here!
  • *****
  • Posts: 5193
Re: The 25 August 2007 build will NOT be out.
« Reply #3 on: August 26, 2007, 08:22:58 am »
no It was not reverted. And as stated in an other thread, the precompiled header include should be removed (this will not cause a crash, I think, but can lead to 'not building').

Offline MortenMacFly

  • Administrator
  • Lives here!
  • *****
  • Posts: 9508
Re: The 25 August 2007 build will NOT be out.
« Reply #4 on: August 26, 2007, 10:05:11 am »
Martin reverted it though? So... nothing to solve?
No, I didn't revert. I don't revert code I don't understand - and I was under the assumption you had a good reason for your revert...?!
Compiler logging: Settings->Compiler & Debugger->tab "Other"->Compiler logging="Full command line"
C::B Manual: http://www.codeblocks.org/docs/main_codeblocks_en.html
C::B FAQ: http://wiki.codeblocks.org/index.php?title=FAQ

Offline stahta01

  • Lives here!
  • ****
  • Posts: 6672
    • My Best Post
Re: The 25 August 2007 build will NOT be out.
« Reply #5 on: August 27, 2007, 01:56:46 am »
no It was not reverted. And as stated in an other thread, the precompiled header include should be removed (this will not cause a crash, I think, but can lead to 'not building').

Builds under windows OK without precompiled header include.

Tim S
C Programmer working to learn more about C++ and Git.
On Windows 7 64 bit and Windows 10 32 bit.
On Debian Stretch, compiling CB Trunk against wxWidgets 3.0.
--
When in doubt, read the CB WiKi FAQ. http://wiki.codeblocks.org