Author Topic: BOUNTY: Notebook class with "close" button at the right  (Read 93720 times)

Offline takeshi miya

  • Lives here!
  • ****
  • Posts: 1487
Re: BOUNTY: Notebook class with "close" button at the right
« Reply #30 on: December 31, 2005, 07:01:31 am »
Just a thought, we can merge that with the new wxAUI. That would be amazing! :D

Offline Ceniza

  • Developer
  • Lives here!
  • *****
  • Posts: 1442
    • CenizaSOFT
Re: BOUNTY: Notebook class with "close" button at the right
« Reply #31 on: December 31, 2005, 08:05:14 am »
Ok, I got the first screenshot of how could it look applied. It was made by playing with MS Paint :)

[attachment deleted by admin]

Offline Ceniza

  • Developer
  • Lives here!
  • *****
  • Posts: 1442
    • CenizaSOFT
Re: BOUNTY: Notebook class with "close" button at the right
« Reply #32 on: December 31, 2005, 06:28:38 pm »
Ok, I just asked the author if we could take his code and use it four our purposes and he accepted. The code is under the wxWidgets license BTW.

So, any objections or suggestions or acceptance?

Offline Game_Ender

  • Lives here!
  • ****
  • Posts: 551
Re: BOUNTY: Notebook class with "close" button at the right
« Reply #33 on: December 31, 2005, 10:29:42 pm »
I certainly like, the current tab system could use this update.

Offline thomas

  • Administrator
  • Lives here!
  • *****
  • Posts: 3979
Re: BOUNTY: Notebook class with "close" button at the right
« Reply #34 on: December 31, 2005, 11:20:28 pm »
We would have to tweak the tab drawing a bit, it seems to draw tabs too small... but except for that it looks ok.
"We should forget about small efficiencies, say about 97% of the time: Premature quotation is the root of public humiliation."

Offline Ceniza

  • Developer
  • Lives here!
  • *****
  • Posts: 1442
    • CenizaSOFT
Re: BOUNTY: Notebook class with "close" button at the right
« Reply #35 on: January 01, 2006, 06:42:53 am »
Draw tabs bigger... no problem with that.

I've considered to implement tab dragging and maybe scroll tabs with the mouse wheel, but first, it must be as far as possible a straight replacement for the current wxNotebook as used by Code::Blocks, after that all the new toys can come in.

I'll start working on it next week (so far I've only made a few minor fixes here and there) when I get back home.

Offline Ceniza

  • Developer
  • Lives here!
  • *****
  • Posts: 1442
    • CenizaSOFT
Re: BOUNTY: Notebook class with "close" button at the right
« Reply #36 on: January 02, 2006, 06:00:56 am »
Well, it seems people just keeps working on it. It's the way the Test program looks right now using the VC71 Style.

Now I really want it to be added to Code::Blocks :)

[attachment deleted by admin]

Offline takeshi miya

  • Lives here!
  • ****
  • Posts: 1487
Re: BOUNTY: Notebook class with "close" button at the right
« Reply #37 on: January 02, 2006, 06:09:48 am »
I like it, but at the same time I have the "ughh it's Visual Studio 2003" feeling :lol:

Offline eranif

  • Regular
  • ***
  • Posts: 254
Re: BOUNTY: Notebook class with "close" button at the right
« Reply #38 on: January 02, 2006, 09:54:08 am »
Hi,

I am the author of the wxFlatNotebook class - If you want some differnt style - just let me know.

If you dont like the VC71 style - you can use the standard style, or wait until I will finish the gradient colored tabs (wont take long now)

Anyway, if you find a bug, just let me know (I did fix the borders when no images are assigned to a tab :))

My target is that this control to be mature and bug free

Regards,
Eran

Offline mandrav

  • Project Leader
  • Administrator
  • Lives here!
  • *****
  • Posts: 4291
    • Code::Blocks IDE
Re: BOUNTY: Notebook class with "close" button at the right
« Reply #39 on: January 02, 2006, 09:58:45 am »
@Ceniza: can you post your test project so I can take a look at it?

@eranif: seems you 've done a good job there (judging from screenshots only) :)
Be patient!
This bug will be fixed soon...

Offline takeshi miya

  • Lives here!
  • ****
  • Posts: 1487
Re: BOUNTY: Notebook class with "close" button at the right
« Reply #40 on: January 02, 2006, 10:13:48 am »
If you dont like the VC71 style - you can use the standard style, or wait until I will finish the gradient colored tabs (wont take long now)

Great! I for sure always preffer native over non-native, that's what I like about wxWidgets :)
Keep the good job! I hope it will be used in C::B soon :D

Offline Ceniza

  • Developer
  • Lives here!
  • *****
  • Posts: 1442
    • CenizaSOFT
Re: BOUNTY: Notebook class with "close" button at the right
« Reply #41 on: January 02, 2006, 10:22:48 am »
Hi eranif, and welcome to this forums :)

It's pretty interesting to see how quickly it's being developed. Just a few days and it has almost everything needed by Code::Blocks.

I saw you just added RemovePage and OnMouseLeave.

An easy one to add, also used by Code::Blocks, is GetPageText (it's in wxPageContainer but not in wxFlatNotebook).

About the style, I like the VC71 one :)

Just like suggested in wxforum, adding a "close with double/middle click" would be nice too.

I tried to integrate it with Code::Blocks already but I got a really weird error that GDB isn't even catching.

Another set of functions used by Code::Blocks are the ImageList ones, but you said you had problems with the alpha channel doing it that way so you disabled them.

Oh, one last thing, being able to disable the X button would be handy too (for Code::Blocks, Messages and Management shouldn't allow the user to close a tab).

Sorry for the mess :P

mandrav: the test program is already included with wxFlatNotebook, but I'll attach his current version with Code::Blocks project files. Haven't tested with UNICODE build yet.

[attachment deleted by admin]

Offline mandrav

  • Project Leader
  • Administrator
  • Lives here!
  • *****
  • Posts: 4291
    • Code::Blocks IDE
Re: BOUNTY: Notebook class with "close" button at the right
« Reply #42 on: January 02, 2006, 10:41:51 am »
mandrav: the test program is already included with wxFlatNotebook, but I'll attach his current version with Code::Blocks project files. Haven't tested with UNICODE build yet.

Thanks :)
Be patient!
This bug will be fixed soon...

Offline eranif

  • Regular
  • ***
  • Posts: 254
Re: BOUNTY: Notebook class with "close" button at the right
« Reply #43 on: January 02, 2006, 01:33:39 pm »
Hi,

I just wanted to let you know that added the GetPageText() API + Middle mouse button for closing tabs, and in addition I also added new
style for tabbing - so you might want to consider it if you dont like the current ones

So currently there are 3 style to choose from:

Fancy style:


VC71 style:


And the default style:


Eran

Offline 280Z28

  • Regular
  • ***
  • Posts: 397
  • *insert unicode here*
Re: BOUNTY: Notebook class with "close" button at the right
« Reply #44 on: January 02, 2006, 01:49:15 pm »
Can you make middle mouse = close a runtime option? I hate that "feature." I know other people like it so it's great that you have implemented it. :)

Can you also make an option to have a close button on each tab, with the option to have it either on the right or on the left? :)

I'd like to incorporate your work with a new branch of wxAUI. It has *huge* potential as the tab layout for stacked dockable panes. Are you up for this? I'm going to set up a public Subversion repository for my working copy of wxAUI today.
« Last Edit: January 02, 2006, 01:53:36 pm by 280Z28 »
78 280Z, "a few bolt-ons" - 12.71@109.04
99 Trans Am, "Daily Driver" - 525rwhp/475rwtq
 Check out The Sam Zone :cool: