Author Topic: [wxSmith]: 2 minor issues  (Read 3446 times)

Offline MortenMacFly

  • Administrator
  • Lives here!
  • *****
  • Posts: 9496
[wxSmith]: 2 minor issues
« on: May 30, 2007, 08:26:43 am »
Dear Byo,
2 minor issues I've  just discovered:
1.) wxscoder.cpp: Line 171 should read:
Code: [Select]
for ( size_t i=0; i<Content.Length(); i++ )to avoid compiler warnings.
2.) wxscustombutton.cpp: Line 99:
Code: [Select]
Style.RemoveLast();is not compatible with wx 2.6.x as there is no such method "RemoveLast()". Maybe you will guard this?
With regards, Morten.
Compiler logging: Settings->Compiler & Debugger->tab "Other"->Compiler logging="Full command line"
C::B Manual: http://www.codeblocks.org/docs/main_codeblocks_en.html
C::B FAQ: http://wiki.codeblocks.org/index.php?title=FAQ

Offline byo

  • Plugin developer
  • Lives here!
  • ****
  • Posts: 837
Re: [wxSmith]: 2 minor issues
« Reply #1 on: May 30, 2007, 10:40:26 am »
Dear Byo,
2 minor issues I've  just discovered:
1.) wxscoder.cpp: Line 171 should read:
Code: [Select]
for ( size_t i=0; i<Content.Length(); i++ )to avoid compiler warnings.

Right, that's correct.

Quote
2.) wxscustombutton.cpp: Line 99:
Code: [Select]
Style.RemoveLast();is not compatible with wx 2.6.x as there is no such method "RemoveLast()". Maybe you will guard this?
With regards, Morten.

And can't agree with this, function exist in both 2.6.4 and 2.8.4 (I've checked docs and header files)

Regards
  BYO

Offline MortenMacFly

  • Administrator
  • Lives here!
  • *****
  • Posts: 9496
Re: [wxSmith]: 2 minor issues
« Reply #2 on: May 30, 2007, 11:13:53 am »
And can't agree with this, function exist in both 2.6.4 and 2.8.4 (I've checked docs and header files)
Sorry Byo, my mistake. I meant: EndsWith() in line 97. The error is:
Code: [Select]
C:\Devel\CodeBlocks\src\plugins\contrib\wxSmithContribItems\wxthings\wxscustombutton.cpp:97: error: 'class wxString' has no member named 'EndsWith'
Sorry... ;-)
With regard, Morten.
Compiler logging: Settings->Compiler & Debugger->tab "Other"->Compiler logging="Full command line"
C::B Manual: http://www.codeblocks.org/docs/main_codeblocks_en.html
C::B FAQ: http://wiki.codeblocks.org/index.php?title=FAQ

Offline byo

  • Plugin developer
  • Lives here!
  • ****
  • Posts: 837
Re: [wxSmith]: 2 minor issues
« Reply #3 on: May 30, 2007, 07:47:50 pm »
And can't agree with this, function exist in both 2.6.4 and 2.8.4 (I've checked docs and header files)
Sorry Byo, my mistake. I meant: EndsWith() in line 97. The error is:
Code: [Select]
C:\Devel\CodeBlocks\src\plugins\contrib\wxSmithContribItems\wxthings\wxscustombutton.cpp:97: error: 'class wxString' has no member named 'EndsWith'
Sorry... ;-)
With regard, Morten.

Hmm, now you're right. But finally I had to remove EndsWith because this code was buggy (fixed version doesn't require EndsWith call).

Thanks for reporting :)

BYO