debugger plugin - WARNING! uninitialized variable

[rickg22]

I was compiling today's svn, and noticed the following error:

G:\projects\codeblocks\src\plugins\debuggergdb\debuggergdb.cpp:951: warning: 'tgtIdx' might be used uninitialized in this function

The line is:
            int tgtIdx = project->SelectTarget(tgtIdx);

It worries me. The SelectTarget uses as the parameter, an initialized value. How to handle this?

[MortenMacFly]

            int tgtIdx = project->SelectTarget(tgtIdx);

Yay, thats a bad one. I think it should be:

Code

  int tgtIdx = project->SelectTarget();

This will use the default value -1 as initial target which is good since the requested build target is not valid (see line 949). Don't know who did that, but I suspect Yiannis... :twisted: ;-)
With regards, Morten.

[mandrav]

            int tgtIdx = project->SelectTarget(tgtIdx);

Yay, thats a bad one. I think it should be:

Code

  int tgtIdx = project->SelectTarget();

This will use the default value -1 as initial target which is good since the requested build target is not valid (see line 949). Don't know who did that, but I suspect Yiannis... :twisted: ;-)
With regards, Morten.

Don't suspect... be sure it was me :lol:.
Someone correct this please (sorry, my time is really limited atm).

[Biplab]

Someone correct this please (sorry, my time is really limited atm).

Corrected.

[rickg22]

Yay! I spotted a bug made by Yiannis! 

*Back in the saddle again...*  :lol: