Author Topic: The 06 October 2019 build (11872) is out.  (Read 2823 times)

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 12002
    • Travis build status
Re: The 06 October 2019 build (11872) is out.
« Reply #30 on: October 12, 2019, 12:43:31 am »
@MaxGaspa: Are you installing the new night build in a clean folder or are you overriding an old folder? The flags should work correctly, at least they work on two of my systems.
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline MaxGaspa

  • Almost regular
  • **
  • Posts: 133
Re: The 06 October 2019 build (11872) is out.
« Reply #31 on: October 14, 2019, 08:28:29 am »
@MaxGaspa: Are you installing the new night build in a clean folder or are you overriding an old folder? The flags should work correctly, at least they work on two of my systems.

I'm deleting everything in the installation directory (c:\Codeblocks) before unpacking the new nightly. Then I create the folder

C:\Codeblocks\share\CodeBlocks\SpellChecker

where I copy the SpellChecker files. The spellchecker works fine just the flags are not shown. I'm attaching a snapshot of my files copied in the spellchecker folder and a snapshot of the spellchecker configuration.

The previous used nightly (11781) was showing the flags correctly. It may be a local issue....and I can live with it :-) it's a real minor issue.



Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 12002
    • Travis build status
Re: The 06 October 2019 build (11872) is out.
« Reply #32 on: October 14, 2019, 07:54:44 pm »
Hm, there is a step you're not showing here.
The images for the spellchecker must be in sized folders.
They should look like 16x16, 20x20,... 64x64.
If they aren't something is wrong.
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline Miguel Gimenez

  • Regular
  • ***
  • Posts: 341
Re: The 06 October 2019 build (11872) is out.
« Reply #33 on: October 14, 2019, 08:15:44 pm »
The nightly's share/CodeBlocks/SpellChecker folder has only an xml file
The same folder in my devel31 folder has nine nnxnn subfolders, 11 flags in png format and the xml
The same folder in my output31 folder has the 11 flags in png format and the xml

Seems like the update31.bat does not copy the folders from devel31 to output31, and the flags in png are a residue of previous revisions

Offline MaxGaspa

  • Almost regular
  • **
  • Posts: 133
Re: The 06 October 2019 build (11872) is out.
« Reply #34 on: October 14, 2019, 08:36:21 pm »
Hm, there is a step you're not showing here.
The images for the spellchecker must be in sized folders.
They should look like 16x16, 20x20,... 64x64.
If they aren't something is wrong.

I created a folder "16x11". The subfolder is still empty but it works now!!! The flags are shown  as expected even if I didn't copy the flag files in the 16x11 subfolder...strange!

I never created such a folder and no nightly archive is creating it. The archive is containing the flags in the ....\share\CodeBlocks\SpellChecker with no sized sub-folder.

Anyway now it works! Thank you for your suggestion.

Max
« Last Edit: October 14, 2019, 08:40:58 pm by MaxGaspa »

Offline sodev

  • Regular
  • ***
  • Posts: 325
Re: The 06 October 2019 build (11872) is out.
« Reply #35 on: October 14, 2019, 08:46:36 pm »
Interesting, SpellChecker has its own update.bat like FortranProject, but in constrast to the latter, the former actually does also handle the copying of devel to output. However the plain xcopy does not process the image subdirectories hence they are missing. The question when this should be fixed is, who is responsible for copying the resources from devel to output? The plugin itself or the master update.bat?

About the nightly, i didn't check it, probably it wasn't created from a clean source tree and there are remaining files from previous versions that didn't use different size versions. The machine that builds the nightlies should be cleaned and do a fresh build :)

Offline stahta01

  • Lives here!
  • ****
  • Posts: 6636
    • My Best Post
Re: The 06 October 2019 build (11872) is out.
« Reply #36 on: October 14, 2019, 09:32:14 pm »
Interesting, SpellChecker has its own update.bat like FortranProject, but in constrast to the latter, the former actually does also handle the copying of devel to output. However the plain xcopy does not process the image subdirectories hence they are missing. The question when this should be fixed is, who is responsible for copying the resources from devel to output? The plugin itself or the master update.bat?

About the nightly, i didn't check it, probably it wasn't created from a clean source tree and there are remaining files from previous versions that didn't use different size versions. The machine that builds the nightlies should be cleaned and do a fresh build :)

My opinion is the master update batch file should copy from devel to output folder.
Note: This is not true for several plugins that do copy to output folder.

Tim S.
 
C Programmer working to learn more about C++ and Git.
On Windows 7 64 bit and Windows 10 32 bit.
On Debian Stretch, compiling CB Trunk against wxWidgets 3.0.
--
When in doubt, read the CB WiKi FAQ. http://wiki.codeblocks.org

Offline killerbot

  • Administrator
  • Lives here!
  • *****
  • Posts: 5179
Re: The 06 October 2019 build (11872) is out.
« Reply #37 on: Yesterday at 09:57:57 am »
Interesting, SpellChecker has its own update.bat like FortranProject, but in constrast to the latter, the former actually does also handle the copying of devel to output. However the plain xcopy does not process the image subdirectories hence they are missing. The question when this should be fixed is, who is responsible for copying the resources from devel to output? The plugin itself or the master update.bat?

About the nightly, i didn't check it, probably it wasn't created from a clean source tree and there are remaining files from previous versions that didn't use different size versions. The machine that builds the nightlies should be cleaned and do a fresh build :)

will take care of that for the next one ;-)

Offline gd_on

  • Regular
  • ***
  • Posts: 472
Re: The 06 October 2019 build (11872) is out.
« Reply #38 on: Yesterday at 07:25:36 pm »
The problem with the flag  is a little bit different for me.
In Libre office or Thunderbird, the name of dictionaries are in my case fr.dic and fr.aff.
The name of the file flag used by SpellChecker is fr_FR.png.
Apparently the name of the dictionnary is used to build the name of the file flag (if I understand the code in StatusField.cpp, SpellCheckerStatusField::Update). So, it's not found.
But if I rename fr_FR.png in fr.png in C:\Program Files\CodeBlocks_wx313_64\share\CodeBlocks\SpellChecker\16x16 for me), the flag appears.

gd_on
« Last Edit: Yesterday at 07:56:00 pm by gd_on »
Windows 10 or 7, svn C::B (last version or almost!), WxWidgets 3.1.2, Compilers 8.1.0, 32 bits (sjlj, posix : gcc and gfortran installed in C:\MinGW32) or 64 bits by Compilers 8.1.0 (seh, posix : in C:\MinGW64).