Author Topic: Toolbar width problem with wxWidgets 3.1.4  (Read 1426 times)

Offline gd_on

  • Lives here!
  • ****
  • Posts: 561
Toolbar width problem with wxWidgets 3.1.4
« on: January 15, 2020, 02:00:08 pm »
I am trying to test wxWidgets 3.1.4 (updated with git).
I have seen, some time ago, that some toolbars in CodeBlocks are too wide with this version but they were correct with 3.1.3 version.
It appeared very soon after the first releases of version 3.1.4 and hasn't changed since.
May be, there is something to tweak in C::B, but I have not found where it is.
See the effects on the 2 images.

gd_on
Windows 10, svn C::B (last version or almost!), WxWidgets 3.1.4 (git), Compilers 8.1.0, 64 bits (seh, posix : gcc, g++ and gfortran in C:\MinGW64) or 32 bits (sjlj, posix in C:\MinGW32). Tests and switch to msys2 and gcc 10.1 compilers.

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 12685
    • Travis build status
Re: Toolbar width problem with wxWidgets 3.1.4
« Reply #1 on: January 15, 2020, 08:44:35 pm »
Does any of View -> Toolbars -> Fit toolbars or optimize toolbars fixes this?
If not bisecting the offending commit in wxwidgets might be helpful.
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline gd_on

  • Lives here!
  • ****
  • Posts: 561
Re: Toolbar width problem with wxWidgets 3.1.4
« Reply #2 on: January 16, 2020, 09:51:44 am »
Quote
Does any of View -> Toolbars -> Fit toolbars or optimize toolbars fixes this?
No, it does not solve the problem.
Quote
If not bisecting the offending commit in wxwidgets might be helpful.
The switch between versions 3.1.3 and 3.1.4 took place on 27/10/2019. So, it will not be easy, and surely take a long time to do that...
I tried tp search why some toolbars were correctly sized and some other were not ... but I have not found ...

gd_on
Windows 10, svn C::B (last version or almost!), WxWidgets 3.1.4 (git), Compilers 8.1.0, 64 bits (seh, posix : gcc, g++ and gfortran in C:\MinGW64) or 32 bits (sjlj, posix in C:\MinGW32). Tests and switch to msys2 and gcc 10.1 compilers.

Offline sodev

  • Regular
  • ***
  • Posts: 387
Re: Toolbar width problem with wxWidgets 3.1.4
« Reply #3 on: January 16, 2020, 01:38:52 pm »
I am observing the same behavior, it seems that only toolbars which contain a control, in both cases a combobox like one, are affected.

Offline Miguel Gimenez

  • Regular
  • ***
  • Posts: 454
Re: Toolbar width problem with wxWidgets 3.1.4
« Reply #4 on: January 16, 2020, 04:19:19 pm »
Your commit is Prevent spurious debug error messages in wxMSW wxToolBar code

https://github.com/wxWidgets/wxWidgets/commit/6878a46725af106758fe166f1334978b89f4a564

EDIT: I have attached the old and new parts of the file. The problem is the toolIndex variable now is incremented only if the tool is not a control. This should be reported to wx devs.

EDIT2: Reported
« Last Edit: January 16, 2020, 05:11:10 pm by Miguel Gimenez »

Offline gd_on

  • Lives here!
  • ****
  • Posts: 561
Re: Toolbar width problem with wxWidgets 3.1.4
« Reply #5 on: January 16, 2020, 06:27:18 pm »
Thanks Miguel.
I was on the good way, but you win  :D
So, we have to wait for a wxWidgets correction probably.
Windows 10, svn C::B (last version or almost!), WxWidgets 3.1.4 (git), Compilers 8.1.0, 64 bits (seh, posix : gcc, g++ and gfortran in C:\MinGW64) or 32 bits (sjlj, posix in C:\MinGW32). Tests and switch to msys2 and gcc 10.1 compilers.

Offline Miguel Gimenez

  • Regular
  • ***
  • Posts: 454
Re: Toolbar width problem with wxWidgets 3.1.4
« Reply #6 on: January 16, 2020, 07:45:43 pm »
Sorry, I didn't realize you were already working on this.

Offline Miguel Gimenez

  • Regular
  • ***
  • Posts: 454

Offline gd_on

  • Lives here!
  • ****
  • Posts: 561
[Solved] Re: Toolbar width problem with wxWidgets 3.1.4
« Reply #8 on: January 17, 2020, 10:36:46 am »
Thanks again, it's OK now. Thanks also to the author of the patch.
And don't be sorry, you are (one of) the best  ;)

gd_on
Windows 10, svn C::B (last version or almost!), WxWidgets 3.1.4 (git), Compilers 8.1.0, 64 bits (seh, posix : gcc, g++ and gfortran in C:\MinGW64) or 32 bits (sjlj, posix in C:\MinGW32). Tests and switch to msys2 and gcc 10.1 compilers.