Author Topic: The 06 October 2019 build (11872) is out.  (Read 6502 times)

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 12069
    • Travis build status
Re: The 06 October 2019 build (11872) is out.
« Reply #30 on: October 12, 2019, 12:43:31 am »
@MaxGaspa: Are you installing the new night build in a clean folder or are you overriding an old folder? The flags should work correctly, at least they work on two of my systems.
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline MaxGaspa

  • Almost regular
  • **
  • Posts: 133
Re: The 06 October 2019 build (11872) is out.
« Reply #31 on: October 14, 2019, 08:28:29 am »
@MaxGaspa: Are you installing the new night build in a clean folder or are you overriding an old folder? The flags should work correctly, at least they work on two of my systems.

I'm deleting everything in the installation directory (c:\Codeblocks) before unpacking the new nightly. Then I create the folder

C:\Codeblocks\share\CodeBlocks\SpellChecker

where I copy the SpellChecker files. The spellchecker works fine just the flags are not shown. I'm attaching a snapshot of my files copied in the spellchecker folder and a snapshot of the spellchecker configuration.

The previous used nightly (11781) was showing the flags correctly. It may be a local issue....and I can live with it :-) it's a real minor issue.



Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 12069
    • Travis build status
Re: The 06 October 2019 build (11872) is out.
« Reply #32 on: October 14, 2019, 07:54:44 pm »
Hm, there is a step you're not showing here.
The images for the spellchecker must be in sized folders.
They should look like 16x16, 20x20,... 64x64.
If they aren't something is wrong.
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline Miguel Gimenez

  • Regular
  • ***
  • Posts: 369
Re: The 06 October 2019 build (11872) is out.
« Reply #33 on: October 14, 2019, 08:15:44 pm »
The nightly's share/CodeBlocks/SpellChecker folder has only an xml file
The same folder in my devel31 folder has nine nnxnn subfolders, 11 flags in png format and the xml
The same folder in my output31 folder has the 11 flags in png format and the xml

Seems like the update31.bat does not copy the folders from devel31 to output31, and the flags in png are a residue of previous revisions

Offline MaxGaspa

  • Almost regular
  • **
  • Posts: 133
Re: The 06 October 2019 build (11872) is out.
« Reply #34 on: October 14, 2019, 08:36:21 pm »
Hm, there is a step you're not showing here.
The images for the spellchecker must be in sized folders.
They should look like 16x16, 20x20,... 64x64.
If they aren't something is wrong.

I created a folder "16x11". The subfolder is still empty but it works now!!! The flags are shown  as expected even if I didn't copy the flag files in the 16x11 subfolder...strange!

I never created such a folder and no nightly archive is creating it. The archive is containing the flags in the ....\share\CodeBlocks\SpellChecker with no sized sub-folder.

Anyway now it works! Thank you for your suggestion.

Max
« Last Edit: October 14, 2019, 08:40:58 pm by MaxGaspa »

Offline sodev

  • Regular
  • ***
  • Posts: 329
Re: The 06 October 2019 build (11872) is out.
« Reply #35 on: October 14, 2019, 08:46:36 pm »
Interesting, SpellChecker has its own update.bat like FortranProject, but in constrast to the latter, the former actually does also handle the copying of devel to output. However the plain xcopy does not process the image subdirectories hence they are missing. The question when this should be fixed is, who is responsible for copying the resources from devel to output? The plugin itself or the master update.bat?

About the nightly, i didn't check it, probably it wasn't created from a clean source tree and there are remaining files from previous versions that didn't use different size versions. The machine that builds the nightlies should be cleaned and do a fresh build :)

Offline stahta01

  • Lives here!
  • ****
  • Posts: 6664
    • My Best Post
Re: The 06 October 2019 build (11872) is out.
« Reply #36 on: October 14, 2019, 09:32:14 pm »
Interesting, SpellChecker has its own update.bat like FortranProject, but in constrast to the latter, the former actually does also handle the copying of devel to output. However the plain xcopy does not process the image subdirectories hence they are missing. The question when this should be fixed is, who is responsible for copying the resources from devel to output? The plugin itself or the master update.bat?

About the nightly, i didn't check it, probably it wasn't created from a clean source tree and there are remaining files from previous versions that didn't use different size versions. The machine that builds the nightlies should be cleaned and do a fresh build :)

My opinion is the master update batch file should copy from devel to output folder.
Note: This is not true for several plugins that do copy to output folder.

Tim S.
 
C Programmer working to learn more about C++ and Git.
On Windows 7 64 bit and Windows 10 32 bit.
On Debian Stretch, compiling CB Trunk against wxWidgets 3.0.
--
When in doubt, read the CB WiKi FAQ. http://wiki.codeblocks.org

Offline killerbot

  • Administrator
  • Lives here!
  • *****
  • Posts: 5188
Re: The 06 October 2019 build (11872) is out.
« Reply #37 on: October 15, 2019, 09:57:57 am »
Interesting, SpellChecker has its own update.bat like FortranProject, but in constrast to the latter, the former actually does also handle the copying of devel to output. However the plain xcopy does not process the image subdirectories hence they are missing. The question when this should be fixed is, who is responsible for copying the resources from devel to output? The plugin itself or the master update.bat?

About the nightly, i didn't check it, probably it wasn't created from a clean source tree and there are remaining files from previous versions that didn't use different size versions. The machine that builds the nightlies should be cleaned and do a fresh build :)

will take care of that for the next one ;-)

Offline gd_on

  • Regular
  • ***
  • Posts: 488
Re: The 06 October 2019 build (11872) is out.
« Reply #38 on: October 15, 2019, 07:25:36 pm »
The problem with the flag  is a little bit different for me.
In Libre office or Thunderbird, the name of dictionaries are in my case fr.dic and fr.aff.
The name of the file flag used by SpellChecker is fr_FR.png.
Apparently the name of the dictionnary is used to build the name of the file flag (if I understand the code in StatusField.cpp, SpellCheckerStatusField::Update). So, it's not found.
But if I rename fr_FR.png in fr.png in C:\Program Files\CodeBlocks_wx313_64\share\CodeBlocks\SpellChecker\16x16 for me), the flag appears.

gd_on
« Last Edit: October 15, 2019, 07:56:00 pm by gd_on »
Windows 10, svn C::B (last version or almost!), WxWidgets 3.1.3, Compilers 8.1.0, 64 bits (seh, posix : gcc, g++ and gfortran in C:\MinGW64) or 32 bits (sjlj, posix in C:\MinGW32).

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 12069
    • Travis build status
Re: The 06 October 2019 build (11872) is out.
« Reply #39 on: October 19, 2019, 01:13:28 pm »
@killerbot: This should be fixed in master.

@gd: This is separate issue, but I don't know what we could do about it. Post a ticket and we might consider it. Have you tried to rename your dictionary to match the flags (no idea if there is something special in the file which prevents renaming)?
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline gd_on

  • Regular
  • ***
  • Posts: 488
Re: The 06 October 2019 build (11872) is out.
« Reply #40 on: October 19, 2019, 06:16:32 pm »
I have created a ticket (#883).
I can rename my Thunderbird dictionaries of course (or in LibreOffice), but it's not a good solution. It's to C::B to build the right name, not to other softs, I think.
As told previously, It's just a minor problem that I can solve temporarilly by renaming the png file (or better by creating a hardlink with LinkShellExtension in Windows).
gd_on
Windows 10, svn C::B (last version or almost!), WxWidgets 3.1.3, Compilers 8.1.0, 64 bits (seh, posix : gcc, g++ and gfortran in C:\MinGW64) or 32 bits (sjlj, posix in C:\MinGW32).

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 12069
    • Travis build status
Re: The 06 October 2019 build (11872) is out.
« Reply #41 on: October 19, 2019, 08:14:21 pm »
It's to C::B to build the right name, not to other softs, I think.
This is true if there is something like a standard for naming. If anybody is free to name its dictionaries files whatever he likes then how are we supposed to select the images?
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline sodev

  • Regular
  • ***
  • Posts: 329
Re: The 06 October 2019 build (11872) is out.
« Reply #42 on: October 19, 2019, 09:08:16 pm »
Well, there is a standard for catalog names, e. g. https://www.gnu.org/software/gettext/manual/html_node/Locale-Names.html. The problem here is that his catalogs don't contain the country code, i think it is a common pattern to fallback to the pure language code in that case.

Offline Frank_CB

  • Multiple posting newcomer
  • *
  • Posts: 53
Re: The 06 October 2019 build (11872) is out.
« Reply #43 on: October 29, 2019, 09:53:52 pm »
Hello,

At least Windows 10 (64-bit) versions of SVN 11887 and SVN 11889 fail to build successfully because of errors in update.bat, which is part of the post build command for the default section for Spellchecker. Update.bat asks for input from the user as displayed below:

Code: [Select]
0 File(s) copied
C:SpellChecker-off.png
C:SpellChecker.png
2 File(s) copied
Copy image files from rc to ..\..\..\devel31_64\share\CodeBlocks\SpellChecker
From rc\16x16 to ..\..\..\devel31_64\share\CodeBlocks\SpellChecker\16x16
Make dir ..\..\..\devel31_64\share\CodeBlocks\SpellChecker\16x16
From rc\20x20 to ..\..\..\devel31_64\share\CodeBlocks\SpellChecker\20x20
Make dir ..\..\..\devel31_64\share\CodeBlocks\SpellChecker\20x20
From rc\24x24 to ..\..\..\devel31_64\share\CodeBlocks\SpellChecker\24x24
Make dir ..\..\..\devel31_64\share\CodeBlocks\SpellChecker\24x24
From rc\28x28 to ..\..\..\devel31_64\share\CodeBlocks\SpellChecker\28x28
Make dir ..\..\..\devel31_64\share\CodeBlocks\SpellChecker\28x28
From rc\32x32 to ..\..\..\devel31_64\share\CodeBlocks\SpellChecker\32x32
Make dir ..\..\..\devel31_64\share\CodeBlocks\SpellChecker\32x32
From rc\40x40 to ..\..\..\devel31_64\share\CodeBlocks\SpellChecker\40x40
Make dir ..\..\..\devel31_64\share\CodeBlocks\SpellChecker\40x40
From rc\48x48 to ..\..\..\devel31_64\share\CodeBlocks\SpellChecker\48x48
Make dir ..\..\..\devel31_64\share\CodeBlocks\SpellChecker\48x48
From rc\56x56 to ..\..\..\devel31_64\share\CodeBlocks\SpellChecker\56x56
Make dir ..\..\..\devel31_64\share\CodeBlocks\SpellChecker\56x56
From rc\64x64 to ..\..\..\devel31_64\share\CodeBlocks\SpellChecker\64x64
Make dir ..\..\..\devel31_64\share\CodeBlocks\SpellChecker\64x64
Does ..\..\..\output31_64\share\CodeBlocks\SpellChecker specify a file name
or directory name on the target
(F = file, D = directory)?


Also there are three REM statements that don't make a lot of sense to me either (as to why they are even there?). It looks almost like somebody had been experimenting and forgot to clean up.

Removing the post build command allows me to build those versions of C::B

Regards!


Offline Miguel Gimenez

  • Regular
  • ***
  • Posts: 369
Re: The 06 October 2019 build (11872) is out.
« Reply #44 on: October 29, 2019, 10:14:36 pm »
Mea culpa, there is already a patch for this at the end of ticket 882