Author Topic: svn 11866 problem  (Read 479 times)

Offline gd_on

  • Regular
  • ***
  • Posts: 488
svn 11866 problem
« on: September 30, 2019, 06:21:51 pm »
When trying to generate svn 11866 I have a problem with EditorConfigCommon.cpp which is not found when using EditorConfig_wx31_64.cbp (on Windows).
Apparently this file has been deleted in svn 11863, is no more used in EditorConfig_wx30_64.cbp (no more used also in unix cbp version) but still appear in wx31 versions (32 and 64 bits).

gd_on
« Last Edit: September 30, 2019, 06:28:38 pm by gd_on »
Windows 10, svn C::B (last version or almost!), WxWidgets 3.1.3, Compilers 8.1.0, 64 bits (seh, posix : gcc, g++ and gfortran in C:\MinGW64) or 32 bits (sjlj, posix in C:\MinGW32).

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 12069
    • Travis build status
Re: svn 11866 problem
« Reply #1 on: September 30, 2019, 06:41:39 pm »
I've forgotten to remove it, sorry. :( Could you remove it and post a working patch?
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline gd_on

  • Regular
  • ***
  • Posts: 488
Re: svn 11866 problem
« Reply #2 on: September 30, 2019, 06:59:08 pm »
I can do that, but I see also that this file is still referenced in wx28_64.cbp (but not in wx28 32 bits version). Sorry, wx28_64 is not officially distributed ! Only old tests on my PC !
3 2 patches (or just even 1 composed patch) to just delete 1 line in 3 2 different cbp files ? is it worthwhile ? because in that case, I'm supposed to generate the 3 2 CB versions and test them ?
You are the developper who modified the files and know exactly what has been done and can decide if a test is worthwhile.
Presently, I'm generating the wx31_64 version with this line deleted and it seems OK until now, but it's not finished.
gd_on
« Last Edit: September 30, 2019, 07:17:44 pm by gd_on »
Windows 10, svn C::B (last version or almost!), WxWidgets 3.1.3, Compilers 8.1.0, 64 bits (seh, posix : gcc, g++ and gfortran in C:\MinGW64) or 32 bits (sjlj, posix in C:\MinGW32).

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 12069
    • Travis build status
Re: svn 11866 problem
« Reply #3 on: September 30, 2019, 07:07:35 pm »
Fix what is immediately bothering you. I'll fix the rest.
Currently I'm running linux and I've not tested on windows, so this is why this problem happened.
It will save me time if you do the testing and it will guarantee that there are more problems.
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline gd_on

  • Regular
  • ***
  • Posts: 488
Re: svn 11866 problem
« Reply #4 on: September 30, 2019, 07:38:03 pm »
Here is a patch.
Apparently works on wx31_64 (at  least compilation OK, but I don't really know what is needed to test !) but not still tested in 32 bits (generation not done ! because I have only a 64 bits wxWidgets 3.1 generated)

gd_on
Windows 10, svn C::B (last version or almost!), WxWidgets 3.1.3, Compilers 8.1.0, 64 bits (seh, posix : gcc, g++ and gfortran in C:\MinGW64) or 32 bits (sjlj, posix in C:\MinGW32).