Author Topic: wxSmith Settings - One radio button is in the wrong group!  (Read 578 times)

Offline tomay3000

  • Multiple posting newcomer
  • *
  • Posts: 39
wxSmith Settings - One radio button is in the wrong group!
« on: October 01, 2019, 09:53:58 pm »
Hello,

I think that the radio button, illustrated in the attached screenshot is in the wrong group.

Thank you.

Offline Miguel Gimenez

  • Regular
  • ***
  • Posts: 371
Re: wxSmith Settings - One radio button is in the wrong group!
« Reply #1 on: October 02, 2019, 10:32:13 am »
Good catch.

The attached patch fixes this. The solution is just adding the wxRB_GROUP flag to one of the radio buttons, but the patch has grown a lot due to wxSmith sorting things. It also changed automatically FlexGridSizer1->Add(0,0,1, wxEXPAND, 5) to FlexGridSizer1->Add(-1,-1,1, wxEXPAND, 5), and this moved the radio buttons to the left.

EDIT: the moving of radio buttons is fixed in the next message's patch
« Last Edit: October 02, 2019, 12:26:23 pm by Miguel Gimenez »

Offline Miguel Gimenez

  • Regular
  • ***
  • Posts: 371
Re: wxSmith Settings - One radio button is in the wrong group!
« Reply #2 on: October 02, 2019, 12:24:49 pm »
This revised patch fixes the original issue and radio buttons moving to the left in the bottom line.

Offline tomay3000

  • Multiple posting newcomer
  • *
  • Posts: 39
Re: wxSmith Settings - One radio button is in the wrong group!
« Reply #3 on: October 02, 2019, 10:10:38 pm »
Thank you, I will try it later.
If it has been applied to svn trunk, I will simply update my local clone, and recompile it.

Offline BlueHazzard

  • Developer
  • Lives here!
  • *****
  • Posts: 2553
Re: wxSmith Settings - One radio button is in the wrong group!
« Reply #4 on: October 03, 2019, 11:43:18 am »
Can you please create a ticket?
I will look into the wxSmith things today...

Offline Miguel Gimenez

  • Regular
  • ***
  • Posts: 371
Re: wxSmith Settings - One radio button is in the wrong group!
« Reply #5 on: October 03, 2019, 12:46:52 pm »
Ticket 875:

https://sourceforge.net/p/codeblocks/tickets/875/

EDIT: can you take a look to the patch in ticket 845?
« Last Edit: October 03, 2019, 01:16:18 pm by Miguel Gimenez »